Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22706 cli testcontainers configuration improvements #25963

Merged

Conversation

dcolina
Copy link
Contributor

@dcolina dcolina commented Aug 31, 2023

Proposed Changes

  • Building CORE docker image for current commit before running cli testcontainers tests.
  • Fixing cli tests reporting status (error cases).
  • Excluding integration tests of surefire plugin.

Fixes

#22706

🤖 Generated by Copilot at 79feafa

This pull request improves the GitHub workflow for building and testing the dotcms image and skips the integration tests in the api-data-model and cli modules to reduce the build time.

🤖 Generated by Copilot at 79feafa

  • Add steps to build and push multi-platform Docker image based on commit sha (link)
  • Modify test job to count and fail on errors in test results (link)
  • Exclude integration tests from api-data-model and cli modules to speed up build process (link, link)

@dcolina dcolina marked this pull request as ready for review September 1, 2023 15:38
@nollymar nollymar linked an issue Sep 6, 2023 that may be closed by this pull request
@nollymar nollymar merged commit 49ab573 into master Sep 6, 2023
@nollymar nollymar deleted the 22706-cli-testcontainers-configuration-improvements branch September 6, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement GHA to run CLI tests
3 participants