Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing step output naming and run command args order. #26718

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

dcolina
Copy link
Contributor

@dcolina dcolina commented Nov 16, 2023

Proposed Changes

  • Fixing step output naming.
  • Run command args order.

Solves

#26534

Summary

🤖[deprecated] Generated by Copilot at c233e8e

This pull request enhances the dotCMS CLI action workflow and script by improving the code quality and adding a new error display option. It affects the files main.yml and run-push.sh in the tools/dotcms-cli/action/.github/workflows directory.

Walkthrough

🤖[deprecated] Generated by Copilot at c233e8e

  • Remove extra space and add newline in main.yml for formatting (link, link)
  • Add DOT_CLI_ERRORS environment variable to main.yml to allow user input for error handling in push command (link)
  • Remove equal signs from push options in main.yml and run-push.sh to match dotCMS CLI syntax (link, link)
  • Change order and name of arguments for run_cli_push function in main.yml and run-push.sh to match dotCMS CLI and avoid confusion (link, link, link)

@dcolina dcolina marked this pull request as ready for review November 16, 2023 18:45
@dcolina dcolina added this pull request to the merge queue Nov 16, 2023
Merged via the queue into master with commit c83c257 Nov 16, 2023
@dcolina dcolina deleted the issue-26386-fix-adding-custom-param-configuration branch November 16, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants