Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Allow custom param configuration in the GHA #26386

Closed
Tracked by #24354
nollymar opened this issue Oct 5, 2023 · 2 comments · Fixed by #26534 or #26743
Closed
Tracked by #24354

CLI: Allow custom param configuration in the GHA #26386

nollymar opened this issue Oct 5, 2023 · 2 comments · Fixed by #26534 or #26743
Labels
dotCMS : CLI Merged QA : Approved QA : Passed Internal Release: 24.03.11 Bug Fixing Team : Scout Type : New Functionality

Comments

@nollymar
Copy link
Contributor

nollymar commented Oct 5, 2023

Parent Issue

No response

User Story

As a user, I want to be able to set the flags and other input sent to the GHA implemented here through a .env file.

Acceptance Criteria

It should work this way:

  • I define a .env file at the root of my github repository. This file is optional and would contain key/value properties with the params I want it to be used when the GHA runs on each push.
  • The GHA should use default params and only consider the ones defined in the .env file if exist.

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@nollymar nollymar mentioned this issue Oct 5, 2023
Closed
@nollymar nollymar moved this from New to Current Sprint Backlog in dotCMS - Product Planning Oct 5, 2023
@nollymar nollymar moved this from Current Sprint Backlog to New in dotCMS - Product Planning Oct 9, 2023
@nollymar nollymar moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Oct 9, 2023
@nollymar nollymar moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning Oct 11, 2023
@dcolina dcolina moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Oct 24, 2023
@dcolina dcolina self-assigned this Oct 24, 2023
dcolina added a commit that referenced this issue Oct 26, 2023
@dcolina
#26386 Loading push command options from .env file.
e63ebd4
@dcolina dcolina mentioned this issue Oct 26, 2023
Merged
@dcolina dcolina moved this from In Progress to In Review in dotCMS - Product Planning Oct 27, 2023
@dcolina dcolina linked a pull request Nov 8, 2023 that will close this issue
#26386 Loading push command options from .env file. #26534
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 9, 2023
@dcolina @fabrizzio-dotCMS
#26386 Loading push command options from .env file. (#26534)
f23411f 
Co-authored-by: daniel.colina <[email protected]>
Co-authored-by: Fabrizzio Araya <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Nov 9, 2023
@nollymar nollymar reopened this Nov 13, 2023
@github-project-automation github-project-automation bot moved this from Done to Current Sprint Backlog in dotCMS - Product Planning Nov 13, 2023
@nollymar nollymar moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Nov 13, 2023
dcolina added a commit that referenced this issue Nov 16, 2023
@dcolina
#26386 Fixing step output naming and run command args order.
c233e8e
@fabrizzio-dotCMS fabrizzio-dotCMS self-assigned this Nov 16, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 16, 2023
@dcolina
#26386 Fixing step output naming and run command args order. (#26718)
c83c257 
Co-authored-by: daniel.colina <[email protected]>
@fabrizzio-dotCMS
Copy link
Contributor

fabrizzio-dotCMS commented Nov 18, 2023 •
edited
Loading

Tested the integration on this public repo https://github.com/fabrizzio-dotCMS/dot-cli-push-3.0
I liked that the params can be passed with and without quotes
e.g.
DOT_CLI_OPTS=" --removeAssets --removeFolders --removeSites --removeContentTypes --removeLanguages"
Passing it.

@fabrizzio-dotCMS fabrizzio-dotCMS removed their assignment Nov 18, 2023
@dcolina dcolina linked a pull request Nov 20, 2023 that will close this issue
#26300 Only one env var is defined to cli options setup. #26743
Merged
@fabrizzio-dotCMS fabrizzio-dotCMS moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Nov 20, 2023
@github-project-automation github-project-automation bot moved this from QA - Backlog to Done in dotCMS - Product Planning Nov 20, 2023
@nollymar nollymar moved this from Done to QA - Backlog in dotCMS - Product Planning Nov 20, 2023
dcolina added a commit that referenced this issue Nov 28, 2023
@dcolina
#26386 Reordering args on the push script calling.
aaab3d4
@dcolina dcolina mentioned this issue Nov 28, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 28, 2023
@dcolina
#26386 Reordering args on the push script calling. (#26819)
57712d8 
Co-authored-by: daniel.colina <[email protected]>
@nollymar nollymar removed the Triage label Dec 17, 2023
@bryanboza
Copy link
Contributor

Fixed, tested on the last CLI version and now I'm able to add myy token to this file and this is working without problems.

@bryanboza bryanboza moved this from QA - Backlog to Done in dotCMS - Product Planning Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dotCMS : CLI Merged QA : Approved QA : Passed Internal Release: 24.03.11 Bug Fixing Team : Scout Type : New Functionality
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
4 participants
@bryanboza @nollymar @dcolina @fabrizzio-dotCMS