Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#26386 Reordering args on the push script calling. #26819

Merged
merged 1 commit into from
Nov 28, 2023
Merged

#26386 Reordering args on the push script calling. #26819

merged 1 commit into from
Nov 28, 2023

Conversation

dcolina
Copy link
Contributor

@dcolina dcolina commented Nov 28, 2023 •
edited
Loading

Proposed Changes

  • Fixing NPE when push script is called on GHA workflow.

Solves

#26386

Summary

Fixed a bug in the push command of the dotCMS CLI when used with GitHub Actions. Changed the order and format of the command arguments in run-push.sh.

@nollymar nollymar added this pull request to the merge queue Nov 28, 2023
Merged via the queue into master with commit 57712d8 Nov 28, 2023
@nollymar nollymar deleted the issue-26386-fix-npe-on-gha-cli-push-command branch November 28, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgambarios jgambarios jgambarios approved these changes

@fabrizzio-dotCMS fabrizzio-dotCMS fabrizzio-dotCMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcolina @jgambarios @fabrizzio-dotCMS @nollymar