Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): fix SDK React secondary entry points #31463

Merged
merged 7 commits into from
Feb 26, 2025

Conversation

rjvelazco
Copy link
Contributor

@rjvelazco rjvelazco commented Feb 25, 2025

Nx and TypeScript docs References

Explanation

This pull request includes various updates to the SDK packages in the core-web/libs directory, focusing on version upgrades and configuration improvements.

Version upgrades:

Configuration improvements:

Video

fix-video-31178-sdk-react-fix-secondary-entry-points.mov

This PR fixes: #31178

@rjvelazco rjvelazco linked an issue Feb 25, 2025 that may be closed by this pull request
8 tasks
Copy link
Member

@fmontes fmontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with some questions.

@KevinDavilaDotCMS KevinDavilaDotCMS marked this pull request as ready for review February 26, 2025 18:50
@zJaaal zJaaal enabled auto-merge February 26, 2025 18:53
@KevinDavilaDotCMS
Copy link
Contributor

To solve the moduleResolution: node issue, ee decided to use typesVersions, which allows us to create subpaths under this module resolution approach and does not affect projects that use a different moduleResolution.

typesVersion doc

@zJaaal zJaaal added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2025
@zJaaal zJaaal added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 4fa1761 Feb 26, 2025
22 checks passed
@zJaaal zJaaal deleted the issue-31178-sdk-react-fix-secondary-entry-points branch February 26, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK: Create DotCMSLayoutBody React Component to render page content
5 participants