Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): fix SDK React secondary entry points #31463

Merged
merged 7 commits into from
Feb 26, 2025
+50 −22
Merged

feat(sdk): fix SDK React secondary entry points #31463

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fc69da2
fix(sdk): define secondary entry points for typescript packages
rjvelazco Feb 25, 2025
a485c5e
fix(sdk): update experiments configuration to fix build
rjvelazco Feb 25, 2025
70bd4b9
fix(sdk): update experiments configuration to fix build v2
rjvelazco Feb 25, 2025
a1c29af
chore: code cleanup
rjvelazco Feb 25, 2025
f45976d
Added config to fix subpaths on moduleResolution:node
kevindaviladev Feb 26, 2025
83e2e67
Fixed paths on tsconfig - core-web
kevindaviladev Feb 26, 2025
5648a38
Fixed additional entry point on react lib and reduced package.json on…
kevindaviladev Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core-web/libs/sdk/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dotcms/client",
"version": "0.0.1-alpha.38",
"version": "0.0.1-beta.2",
"description": "Official JavaScript library for interacting with DotCMS REST APIs.",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion core-web/libs/sdk/experiments/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dotcms/experiments",
"version": "0.0.1-alpha.38",
"version": "0.0.1-beta.2",
"description": "Official JavaScript library to use Experiments with DotCMS.",
"repository": {
"type": "git",
Expand Down
3 changes: 2 additions & 1 deletion core-web/libs/sdk/experiments/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"allowJs": false,
"esModuleInterop": false,
"allowSyntheticDefaultImports": true,
"strict": true
"strict": true,
"moduleResolution": "bundler"
},
"files": [],
"include": ["src"],
Expand Down
9 changes: 7 additions & 2 deletions core-web/libs/sdk/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dotcms/react",
"version": "0.0.1-alpha.38",
"version": "0.0.1-beta-2",
"peerDependencies": {
"react": ">=18",
"react-dom": ">=18",
Expand All @@ -27,5 +27,10 @@
"bugs": {
"url": "https://github.com/dotCMS/core/issues"
},
"homepage": "https://github.com/dotCMS/core/tree/main/core-web/libs/sdk/react/README.md"
"homepage": "https://github.com/dotCMS/core/tree/main/core-web/libs/sdk/react/README.md",
"exports": {
"./package.json": "./package.json",
".": "./src/index.ts",
"./next": "./src/next.ts"
}
}
6 changes: 4 additions & 2 deletions core-web/libs/sdk/react/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,18 @@
"executor": "@nx/rollup:rollup",
"outputs": ["{options.outputPath}"],
"options": {
"main": "libs/sdk/react/src/index.ts",
"additionalEntryPoints": ["libs/sdk/react/src/next.ts"],
"generateExportsField": true,
"outputPath": "dist/libs/sdk/react",
"tsConfig": "libs/sdk/react/tsconfig.lib.json",
"project": "libs/sdk/react/package.json",
"entryFile": "libs/sdk/react/src/index.ts",
"additionalEntryPoints": ["libs/sdk/react/src/next.ts"],
"external": ["react/jsx-runtime"],
"rollupConfig": "@nrwl/react/plugins/bundle-rollup",
"compiler": "babel",
"format": ["esm", "cjs"],
"extractCss": false,
"format": ["esm"],
"assets": [
{
"glob": "libs/sdk/react/README.md",
Expand Down
2 changes: 1 addition & 1 deletion core-web/libs/sdk/react/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"strict": true
},
"files": [],
"include": [],
"include": ["src/**/*.js", "src/**/*.jsx", "src/**/*.ts", "src/**/*.tsx"],
"references": [
{
"path": "./tsconfig.lib.json"
Expand Down
9 changes: 8 additions & 1 deletion core-web/libs/sdk/react/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,12 @@
"src/**/*.spec.jsx",
"src/**/*.test.jsx"
],
"include": ["src/**/*.js", "src/**/*.jsx", "src/**/*.ts", "src/**/*.tsx"]
"include": [
"src/**/*.js",
"src/**/*.jsx",
"src/**/*.ts",
"src/**/*.tsx",
"next/**/*.ts",
"next/**/*.tsx"
]
}
2 changes: 1 addition & 1 deletion core-web/libs/sdk/uve/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dotcms/uve",
"version": "0.0.1",
"version": "0.0.1-beta.2",
"description": "Official JavaScript library for interacting with Universal Visual Editor (UVE)",
"repository": {
"type": "git",
Expand Down
Loading