-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTK Deprecation #5755
OpenTK Deprecation #5755
Conversation
src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.targets
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Linker/Mobile.Tuner/MobileProfile.cs
Outdated
Show resolved
Hide resolved
daed95f
to
b962dc9
Compare
78b85ac
to
1381cf1
Compare
7c91e6f
to
c98e9c7
Compare
We are going to stop shipping OpenTK-1.0 in a future update. In order to give users who are using that assembly a chance to migrate we will deprecate it first. We will raise a `XA4313` warning if we detect that OpenTK-1.0 is in the `@(Refereces)` item group. A replacement Nuget Package has already been created at https://www.nuget.org/packages/Xamarin.Legacy.OpenTK/ Users seeing this warning should remove the reference to `OpenTK-1.0` and replace it will the following ``` <PackageReference Include="Xamarin.Legacy.OpenTK" Version="0.0.1-alpha" /> ``` The version number will change in the future. The vast majority of changes in this commit are to stop the OpenTK java types being included in `mono-android.jar`. From this point on `OpenTK` will be treated like all other Android Class Libraries, the generated java code will be written to the `$(IntermediateOutputPath)\lp` directory along with all the other references.
...n.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.BuildOrder.targets
Outdated
Show resolved
Hide resolved
|
||
from your csproj then add | ||
|
||
'<PackageReference Include="Xamarin.Legacy.OpenTK" Version="1.0.0" />' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the version should probably be 0.0.1-alpha
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll probably push a release 1.0.0 before we ship this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why those are there. I suspect they will still be needed even with the Nuget. |
They need to be present somewhere, even with the NuGet, and even under .NET 6. That doesn't mean that the xamarin-android repo is the appropriate place fo the ProGuard config info. If possible, can the OpenTK-related statements within |
We are going to stop shipping OpenTK-1.0 in a future update. In order to give users who are using
that assembly a chance to migrate we will deprecate it first.
We will raise a
XA4313
warning if we detect that OpenTK-1.0 is in the@(Refereces)
item group.A replacement Nuget Package has already been created at https://www.nuget.org/packages/Xamarin.Legacy.OpenTK/
Users seeing this warning should remove the reference to
OpenTK-1.0
and replace it will the followingThe version number will change in the future.
The vast majority of changes in this commit are to stop the OpenTK java types being included in
mono-android.jar
.From this point on
OpenTK
will be treated like all other Android Class Libraries, the generated java code will bewritten to the
$(IntermediateOutputPath)\lp
directory along with all the other references.