Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTK Deprecation #5755

Merged
merged 5 commits into from
Apr 26, 2021
Merged

OpenTK Deprecation #5755

merged 5 commits into from
Apr 26, 2021

Conversation

dellis1972
Copy link
Contributor

@dellis1972 dellis1972 commented Mar 17, 2021

We are going to stop shipping OpenTK-1.0 in a future update. In order to give users who are using
that assembly a chance to migrate we will deprecate it first.
We will raise a XA4313 warning if we detect that OpenTK-1.0 is in the @(Refereces) item group.

A replacement Nuget Package has already been created at https://www.nuget.org/packages/Xamarin.Legacy.OpenTK/
Users seeing this warning should remove the reference to OpenTK-1.0 and replace it will the following

<PackageReference Include="Xamarin.Legacy.OpenTK" Version="0.0.1-alpha" />

The version number will change in the future.

The vast majority of changes in this commit are to stop the OpenTK java types being included in mono-android.jar.
From this point on OpenTK will be treated like all other Android Class Libraries, the generated java code will be
written to the $(IntermediateOutputPath)\lp directory along with all the other references.

@dellis1972 dellis1972 force-pushed the opentkstuff branch 2 times, most recently from daed95f to b962dc9 Compare March 26, 2021 09:24
@dellis1972 dellis1972 force-pushed the opentkstuff branch 3 times, most recently from 78b85ac to 1381cf1 Compare April 14, 2021 13:54
@dellis1972 dellis1972 changed the title Initial Commit of OpenTK Deprecation OpenTK Deprecation Apr 16, 2021
@dellis1972 dellis1972 marked this pull request as ready for review April 16, 2021 12:47
@dellis1972 dellis1972 force-pushed the opentkstuff branch 3 times, most recently from 7c91e6f to c98e9c7 Compare April 20, 2021 09:11
We are going to stop shipping OpenTK-1.0 in a future update. In order to give users who are using
that assembly a chance to migrate we will deprecate it first.
We will raise a `XA4313` warning if we detect that OpenTK-1.0 is in the `@(Refereces)` item group.

A replacement Nuget Package has already been created at https://www.nuget.org/packages/Xamarin.Legacy.OpenTK/
Users seeing this warning should remove the reference to `OpenTK-1.0` and replace it will the following

```
<PackageReference Include="Xamarin.Legacy.OpenTK" Version="0.0.1-alpha" />
```

The version number will change in the future.

The vast majority of changes in this commit are to stop the OpenTK java types being included in `mono-android.jar`.
From this point on `OpenTK` will be treated like all other Android Class Libraries, the generated java code will be
written to the `$(IntermediateOutputPath)\lp` directory along with all the other references.

from your csproj then add

'<PackageReference Include="Xamarin.Legacy.OpenTK" Version="1.0.0" />'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the version should probably be 0.0.1-alpha ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll probably push a release 1.0.0 before we ship this.

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dellis1972
Copy link
Contributor Author

Should we remove these, too?

https://github.com/xamarin/xamarin-android/blob/7f32ef06011dfcc4d2f54a6a3fc84cb3ddc7bc50/src/Xamarin.Android.Build.Tasks/Resources/proguard_xamarin.cfg#L13-L16

I'm not sure why those are there. I suspect they will still be needed even with the Nuget.

@jonpryor
Copy link
Member

@dellis1972 wrote:

Should we remove these, too?
https://github.com/xamarin/xamarin-android/blob/7f32ef06011dfcc4d2f54a6a3fc84cb3ddc7bc50/src/Xamarin.Android.Build.Tasks/Resources/proguard_xamarin.cfg#L13-L16

I'm not sure why those are there. I suspect they will still be needed even with the Nuget.

They need to be present somewhere, even with the NuGet, and even under .NET 6.

That doesn't mean that the xamarin-android repo is the appropriate place fo the ProGuard config info. If possible, can the OpenTK-related statements within progurad_xamarin.cfg be copied into the Xamarin.Legacy.OpenTK package? It won't be needed for Legacy SDK, but we should want it for .NET 6.

@jonpryor jonpryor merged commit f909adb into dotnet:main Apr 26, 2021
@dellis1972 dellis1972 deleted the opentkstuff branch April 26, 2021 16:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants