Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow artifacts and dotnet installation directory to be overridden #1293

Open
Tracked by #2053
dsplaisted opened this issue Nov 8, 2018 · 7 comments
Open
Tracked by #2053
Milestone

Comments

@dsplaisted
Copy link
Member

The arcade tools.ps1 and tools.sh scripts currently set the ArtifactsDir or artifacts_dir unconditionally. It looks like they respect the DOTNET_INSTALL_DIR environment variable, but if it is set then it needs to be to a location where the .NET SDK is already installed. There's no way to specify a path to override the location where the scripts will download the .NET SDK to if necessary.

I'd like to be able to override both of these locations with environment variables. RepoLayout.props might also need to be adjusted in sync with the script changes.

This would be helpful because in dotnet/core-sdk, we use Docker to build for various flavors of Linux. This is also useful for local development if we need to work with a specific version of Linux. However, since the repo root is shared from the host to the docker container, the build in the docker container would try to use the version of the .NET SDK that the host had installed, and would produce its output in the same paths as the host OS did. So to do a Docker build, we would need to clean the .dotnet and artifacts folder in the repo. This makes it more painful to switch between building in the host and using Docker.

@tmat

@Chrisboh
Copy link
Member

I dont think this is related to Helix. Kicking back to triage.

@markwilkie
Copy link
Member

@dsplaisted - given the guidance in https://github.com/dotnet/arcade/blob/master/Documentation/DefaultsGuidance.md what do you think the right next steps are?

@dsplaisted
Copy link
Member Author

@markwilkie This isn't really about preference for a different folder, which seems to be what the guidance is about. This is about making it easier to develop for multiple operating systems.

I had sent a PR to allow this, but Tomas had some feedback about it that we never resolved, mainly because this is only a priority for me sporadically, when I have to do OS-specific work.

@markwilkie
Copy link
Member

I see - makes sense. Thoughts on next steps for this issue?

@dsplaisted
Copy link
Member Author

I ended up needing this feature again, so I prototyped @tmat's suggestion from #1471: dotnet/installer@a99199e

How does that look?

@markwilkie
Copy link
Member

The attached PR was stale and got closed - thus, am closing this issue as well.

@tmat
Copy link
Member

tmat commented May 20, 2019

@markwilkie Although we haven't had time to do this the scenario is still valid. I think we should keep the issue open on a backlog.

@markwilkie markwilkie reopened this May 20, 2019
@michellemcdaniel michellemcdaniel mentioned this issue Feb 14, 2022
74 tasks
@missymessa missymessa added this to the Arcade SDK milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants