Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need support for custom build triggers that can set properties #143

Open
Tracked by #2053
maririos opened this issue May 3, 2018 · 9 comments
Open
Tracked by #2053

Need support for custom build triggers that can set properties #143

maririos opened this issue May 3, 2018 · 9 comments
Milestone

Comments

@maririos
Copy link
Member

maririos commented May 3, 2018

@weshaggard commented on Wed Nov 29 2017

There have recently been a need for having build triggers that can setup custom properties. See https://github.com/dotnet/corefx/issues/25382 as an example. We have talked about doing that for signing as well to have at least one signed build a week from master.

Currently the built in VSTS triggers don't allow you to set properties but it seems like it would be easy enough to add this to the maestro infrastructure we already have.


@dagood commented on Wed Nov 29 2017

Agreed it makes sense to use maestro for this, ties in with https://github.com/dotnet/core-eng/issues/936.


@mmitche commented on Tue Feb 20 2018

I have asked VSTS to ensure this is in their config as code solution too.


@weshaggard commented on Tue Feb 20 2018

@mmitche I assume you didn't intend to close. If you did then please point me at the changes that enabled.


@mmitche commented on Tue Feb 20 2018

@weshaggard Not yet. I requested that this be part of VSTS's config as code trigger spec. Different triggers will allow for different parameter sets.


@mmitche commented on Tue Feb 20 2018

So i would not like to do throwaway work here.


@weshaggard commented on Tue Feb 20 2018

It would be great if VSTS can support this but depending on their timeline we might consider still adding this feature to Maestro as it seems like a useful scenario for our Maestro even if we don't use it for this particular purpose.


@mmitche commented on Tue Feb 20 2018

Timeline for them is like....a month from now IIRC.


@mmitche commented on Mon Apr 30 2018

I think we should work with VSTS on this, rather than build support into other tools.


@weshaggard commented on Mon Apr 30 2018

@mmitche I'm fine with that as an approach but I'd still like to keep this open until we have a solution for it.

@markwilkie
Copy link
Member

This is (hopefully) related to the current VSTS effort which is underway to support custom properties as part of a PR. We need to follow up with VSTS to make sure this is generic enough.

@markwilkie
Copy link
Member

@mmitche - should we close this now?

@weshaggard
Copy link
Member

As far as I'm aware this scenario isn't covered by anything yet. For corefx we only run our release builds nightly but would like to setup a trigger to run a debug build once a week but to do that we need some way to set a trigger with a custom property getting set. As far as I can tell VSTS doesn't offer that option.

@markwilkie
Copy link
Member

@chcosta - please follow up w/ Azure DevOps. (not required for preview)

@chcosta
Copy link
Member

chcosta commented Oct 10, 2018

@jcagme
Copy link
Contributor

jcagme commented Oct 31, 2018

Is this required for preview (12/14)?

@weshaggard
Copy link
Member

No it isn't required for preview.

@jcagme
Copy link
Contributor

jcagme commented Feb 11, 2019

Hey @chcosta, microsoft/azure-pipelines-agent#1383 is still open and the last comment was on 10/10/18. Is this still on the works or we can close this issue?

@chcosta
Copy link
Member

chcosta commented Feb 12, 2019

This is still in the works

@michellemcdaniel michellemcdaniel mentioned this issue Feb 14, 2022
74 tasks
@missymessa missymessa added this to the Arcade SDK milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants