-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if SymbolPackageFormat
set to snupkg
#14032
Conversation
cd4e2ec
to
173301e
Compare
To avoid the repeat of dotnet/extensions#4406, warn if SymbolPackageFormat property is set to 'snupkg'. If necessary, the warning can be suppressed with SuppressSymbolPackageFormatValidation=true.
173301e
to
0b4c2a8
Compare
@mmitche @dotnet/arcade-contrib may I please get some guidance with the failing tests? I don't think my change caused those as I see other PRs failing with the same error. |
Just curious, what hinders Arcade from supporting snupkgs? |
#1959 <-- this? |
Nothing specific. The symbol publishing process needs to be updated though. You need to publish a binary with a symbol, and because snupkg doesn't contain the binary, this is a bit more complex than it is today. But we should support snupkg |
The main problem with snupkg is that we can't easily convert portable PDBs to full PDBs without the PE. As the restriction goes away, snupkg makes sense and should be a straightforward migration. |
To avoid the repeat of dotnet/extensions#4406, warn if
SymbolPackageFormat
property is set to 'snupkg'.If necessary, the warning can be suppressed with SuppressSymbolPackageFormatValidation=true.
. . .
Tested locally against https://github.com/dotnet/extensions/ @ ef72a4125a8f7f76b62024e273e90f53453b8f68.
With
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
:With the added suppression (
<SuppressSymbolPackageFormatValidation>true</SuppressSymbolPackageFormatValidation>
):With the property removed: