Fix some Health checks on NuGet packages produced. #4406
Assignees
Labels
Comments
|
@mmitche was kind enough to help me root causing it, and we figured it boiled down to this line: extensions/eng/MSBuild/Packaging.props Line 21 in ef72a41 The Arcade SDK doesn't support snupkg format, and the debug symbols must be in a form of *.symbols.nupkg. |
RussKie
added a commit
to dotnet/arcade
that referenced
this issue
Sep 15, 2023
To avoid the repeat of dotnet/extensions#4406, warn if SymbolPackageFormat property is set to 'snupkg'. If necessary, the warning can be suppressed with SupressSymbolPackageFormatValidation=true.
RussKie
added a commit
to RussKie/extensions
that referenced
this issue
Sep 15, 2023
The Arcade SDK doesn't support "snupkg" format, which means the debug symbols aren't getting published. Fixes dotnet#4406
RussKie
added a commit
to dotnet/arcade
that referenced
this issue
Sep 18, 2023
To avoid the repeat of dotnet/extensions#4406, warn if SymbolPackageFormat property is set to 'snupkg'. If necessary, the warning can be suppressed with SupressSymbolPackageFormatValidation=true.
RussKie
added a commit
to dotnet/arcade
that referenced
this issue
Sep 18, 2023
To avoid the repeat of dotnet/extensions#4406, warn if SymbolPackageFormat property is set to 'snupkg'. If necessary, the warning can be suppressed with SuppressSymbolPackageFormatValidation=true.
RussKie
added a commit
that referenced
this issue
Sep 18, 2023
The Arcade SDK doesn't support "snupkg" format, which means the debug symbols aren't getting published. Fixes #4406
RussKie
added a commit
to dotnet/arcade
that referenced
this issue
Sep 19, 2023
To avoid the repeat of dotnet/extensions#4406, warn if SymbolPackageFormat property is set to 'snupkg'. If necessary, the warning can be suppressed with SuppressSymbolPackageFormatValidation=true.
RussKie
added a commit
to dotnet/arcade
that referenced
this issue
Sep 20, 2023
To avoid the repeat of dotnet/extensions#4406, warn if SymbolPackageFormat property is set to 'snupkg'. If necessary, the warning can be suppressed with SuppressSymbolPackageFormatValidation=true.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If I look at one of the RC1 packages from the dotnet/runtime repo that were shipped yesterday to NuGet, I see the following when opening it with the NuGet Package Explorer:
If you contrast that to one of the RC1 packages produced by dotnet/extensions, you'll see some differences:
I believe we are pushing symbols to Msft symbol servers as well as part of our build, so I'm not sure why this is what is stated here but we should figure out what the problem is and fix it. @RussKie can you please take a look so we make sure we correct this before RC2?
The text was updated successfully, but these errors were encountered: