Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nethost.dll to find dotnet in ANCM #10829

Closed
wants to merge 23 commits into from
Closed

Conversation

jkotalik
Copy link
Contributor

@jkotalik jkotalik commented Jun 4, 2019

Fixes #8838

@jkotalik jkotalik requested review from BrennanConroy and a team June 4, 2019 05:47
Copy link
Contributor

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. If it works, :shipit:

eng/Version.Details.xml Outdated Show resolved Hide resolved
@jkotalik jkotalik added the blocked The work on this issue is blocked due to some dependency label Jun 5, 2019
@jkotalik
Copy link
Contributor Author

jkotalik commented Jun 5, 2019

Got a slight block on dotnet/core-setup#6672

@jkotalik jkotalik force-pushed the jkotalik/hostfxrSpike branch 2 times, most recently from 77d5007 to 151528a Compare June 17, 2019 22:55
@jkotalik jkotalik force-pushed the jkotalik/hostfxrSpike branch from 151528a to 7d8e498 Compare June 19, 2019 20:48
@jkotalik jkotalik removed the blocked The work on this issue is blocked due to some dependency label Jun 19, 2019
@jkotalik jkotalik marked this pull request as ready for review June 19, 2019 21:56
@jkotalik
Copy link
Contributor Author

@BrennanConroy this is now ready for review. No rush though, I know SignalR + Npm is higher priority.

@analogrelay analogrelay added this to the 3.0.0-preview7 milestone Jun 19, 2019
@jkotalik jkotalik added the blocked The work on this issue is blocked due to some dependency label Jun 25, 2019
@jkotalik
Copy link
Contributor Author

Re-adding a blocked label to this. I believe there is a fundamental issue with nethost.dll where it can't accept a path to dotnet. This will break anyone who doesn't specify DOTNET_ROOT, DOTNET_HOME, or dotnet on the path and pass in an absolute path to dotnet.

@jkotalik
Copy link
Contributor Author

jkotalik commented Jul 8, 2019

This will be mostly unblocked by dotnet/core-setup#7020 once we update dependencies.

We will need to keep our logic to find where dotnet is if it is only available via the path. We can still feed the dotnet location to nethost.dll to find hostfxr, but nethost will not path probe.

Here is some pseudo code for how we would find dotnet now:

  • Call nethost passing in either the path to the application dll and/or the path to dotnet.exe.
  • If dotnet.exe isn't found, try to find dotnet on PATH.
  • If we find dotnet.exe, call nethost.dll again with the newly found path to dotnet.

@dougbu
Copy link
Member

dougbu commented Jul 8, 2019

@jkotalik will core-setup packages with version 3.0.0-preview8-27904-06 get you what you need? That was the latest when I manually updated the dependencies a couple of days ago (see #11939).

@jkotalik jkotalik force-pushed the jkotalik/hostfxrSpike branch from d459428 to 2ed35d2 Compare July 16, 2019 16:03
@analogrelay analogrelay added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 23, 2019
@jkotalik jkotalik modified the milestones: 3.0.0-preview8, Backlog Aug 13, 2019
@jkotalik jkotalik removed the tell-mode Indicates a PR which is being merged during tell-mode label Aug 13, 2019
@jkotalik jkotalik closed this Aug 14, 2019
@jkotalik
Copy link
Contributor Author

Closing for now, will reopen one day....

@dougbu dougbu deleted the jkotalik/hostfxrSpike branch August 21, 2021 22:36
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions blocked The work on this issue is blocked due to some dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React to hostfxr locating logic
7 participants