-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nethost.dll to find dotnet in ANCM #10829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. If it works,
Got a slight block on dotnet/core-setup#6672 |
77d5007
to
151528a
Compare
151528a
to
7d8e498
Compare
@BrennanConroy this is now ready for review. No rush though, I know SignalR + Npm is higher priority. |
src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs
Show resolved
Hide resolved
src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs
Show resolved
Hide resolved
src/Hosting/Server.IntegrationTesting/src/Common/DotNetCommands.cs
Outdated
Show resolved
Hide resolved
src/Installers/Windows/AspNetCoreModule-Setup/ANCMIISExpressV2/ancm_iis_expressv2.wxs
Show resolved
Hide resolved
Re-adding a blocked label to this. I believe there is a fundamental issue with nethost.dll where it can't accept a path to dotnet. This will break anyone who doesn't specify DOTNET_ROOT, DOTNET_HOME, or dotnet on the path and pass in an absolute path to dotnet. |
This will be mostly unblocked by dotnet/core-setup#7020 once we update dependencies. We will need to keep our logic to find where dotnet is if it is only available via the path. We can still feed the dotnet location to nethost.dll to find hostfxr, but nethost will not path probe. Here is some pseudo code for how we would find dotnet now:
|
d459428
to
2ed35d2
Compare
Closing for now, will reopen one day.... |
Fixes #8838