Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Export unmangled name for get_hostfxr_path on nethost (Windows x86) #6672

Merged
merged 2 commits into from
Jun 5, 2019

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Jun 4, 2019

The export from declspec(dllexport) includes decoration for the __stdcall calling convention. Explicitly export a non-decorated name for Windows x86.

@elinor-fung elinor-fung force-pushed the nethost-unmangledExport branch from 9a20e4f to d9570d9 Compare June 4, 2019 23:42
@elinor-fung elinor-fung changed the title Export unmangled name for get_hostfxr_path on nethost Export unmangled name for get_hostfxr_path on nethost (Windows x86) Jun 5, 2019
Copy link

@sdmaclea sdmaclea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how the tests relate to the export?

src/corehost/cli/nethost/nethost.cpp Outdated Show resolved Hide resolved
@elinor-fung
Copy link
Member Author

@sdmaclea The changes to tests basically add checking that the exports are as we want and consuming nethost is as expected through both the import lib and an explicit library load. Previously, they were always going through the import lib, so they didn't hit this issue with the calling convention decoration.

Copy link

@sdmaclea sdmaclea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Makes sense now. LGTM

@elinor-fung elinor-fung merged commit 637b9a7 into dotnet:master Jun 5, 2019
@elinor-fung elinor-fung deleted the nethost-unmangledExport branch June 5, 2019 21:56
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants