[release/6.0] Update Helix.Common.props

[JamesNK]

Backport of #45737 to release/6.0

[ghost]

Hi @JamesNK. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

[ghost]

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

[JamesNK]

Failing with:

Playwright does not support chromium on mac12

Playwright version has been updated on main and release/7.0 so it should be a matter of copying those changes to release/6.0.

[JamesNK]

@dotnet/aspnet-build @captainsafia If the change to upgrade Playwright is difficult, then an alternative is to leave the release/6.0 branch targeting OSX.1100.Amd64.Open. If we don't update the branch to 12.0, then Playwright doesn't need to be changed.

[captainsafia]

@dotnet/aspnet-build @captainsafia If the change to upgrade Playwright is difficult, then an alternative is to leave the release/6.0 branch targeting OSX.1100.Amd64.Open. If we don't update the branch to 12.0, then Playwright doesn't need to be changed.

I think there should be a few more tweaks in the ProjectTemplateTests.

Another thing to note is that the Playwright.Sharp package referenced in this branch is deprecated anyways so the upgrade would be prudent regardless.

[HaoK]

@captainsafia I have some concerns with this PR resulting in pretty big deviations from current bits in the infrastructure, there was some refactoring done by @dougbu in 0be2c29

I really think we want to avoid a major chism between test runner/playwright code. I don't think we get much (any?) benefits from running playwright tests on 6.0, so maybe we can just pull the plug on it entirely in servicing if its only for smattering of tests.

[captainsafia]

I really think we want to avoid a major chism between test runner/playwright code. I don't think we get much (any?) benefits from running playwright tests on 6.0, so maybe we can just pull the plug on it entirely in servicing if its only for smattering of tests.

Assuming these Playwright tests aren't providing any value, we might benefit from skipping them altogether. However, if the Playwright tests do need to run in .NET 6, it seems like there is some value in getting us onto the non-deprecated testing library on this branch, especially if it is LTS.

@captainsafia I have some concerns with this PR resulting in pretty big deviations from current bits in the infrastructure, there was some refactoring done by @dougbu in 0be2c29

I believe those deviations exist regardless given that the referenced commit is in 7.0 and 6.0. I didn't modify anything in the TestRunner in 6.0 although I am not sure if your point is that the TestRunner in 6.0 should be updated...

[HaoK]

I just mean this PR contains a lot of changes that look specific to 6.0, like going from selected.Length to Count... and it looks like @TanayParikh removed this directory in main for 7.0 here: 5247048

So I think instead we should just nuke the files in 6.0 as well.

[wtgodbe]

So I think instead we should just nuke the files in 6.0 as well.

If the team has sufficient confidence that the coverage in 7.0/main provides enough validation for 6.0, I'm fine with that

[wtgodbe]

Branches are open for Feb until 1/16

[HaoK]

Cool, replacing this PR with #45852