Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Backport deletion of playwright tests #45852

Merged
merged 6 commits into from
Jan 11, 2023
Merged

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jan 3, 2023

These tests were removed in 5247048 for 7.0, and due to pw having some infrastructure costs, better to remove these in 6.0 rather than update pw infrastructure

@ghost ghost added this to the 6.0.x milestone Jan 3, 2023
@ghost
Copy link

ghost commented Jan 3, 2023

Hi @HaoK. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@HaoK
Copy link
Member Author

HaoK commented Jan 4, 2023

Per discussion with @captainsafia and @TanayParikh these playwright tests were removed in 7.0 so this just backports their removal to 6.0 so we avoid any extra playwright issues

@HaoK HaoK marked this pull request as ready for review January 4, 2023 19:51
@HaoK HaoK requested a review from a team as a code owner January 4, 2023 19:51
@HaoK HaoK requested a review from a team January 4, 2023 19:51
Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TanayParikh
Copy link
Contributor

/azp help

@azure-pipelines
Copy link

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@TanayParikh
Copy link
Contributor

/azp list

@azure-pipelines
Copy link

@TanayParikh
Copy link
Contributor

/azp run aspnetcore-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HaoK
Copy link
Member Author

HaoK commented Jan 5, 2023

@wtgodbe this PR is green, is there any other process we need to follow to get this in, or is this sufficient for the build team to merge during the window?

@dougbu
Copy link
Member

dougbu commented Jan 11, 2023

This PR is test-only. Any reason not to merge it @HaoK

@HaoK
Copy link
Member Author

HaoK commented Jan 11, 2023

Nope, should be good to merge!

@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 11, 2023
@dougbu dougbu merged commit efd5162 into release/6.0 Jan 11, 2023
@dougbu dougbu deleted the haok/pw6 branch January 11, 2023 19:23
@dougbu dougbu modified the milestones: 6.0.x, 6.0.14 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants