Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable producing NETStandard targeting pack in 3.1 branch #3800

Closed
dagood opened this issue Oct 9, 2019 · 2 comments
Closed

Disable producing NETStandard targeting pack in 3.1 branch #3800

dagood opened this issue Oct 9, 2019 · 2 comments
Assignees
Milestone

Comments

@dagood
Copy link
Member

dagood commented Oct 9, 2019

Right now, Core-Setup release/3.1 still produces 2.1-versioned .NET Standard targeting packs with prerelease versions, which is below the 2.1.0 version we produced for 3.0.0 (release/3.0). This is confusing.

We should disable this targeting pack from building. Repos should keep pointing at the released 2.1 targeting pack.

The .NET Standard targeting pack is odd because it doesn't really belong in Core-Setup. That's why the usual approach of bumping up the version isn't an obvious solution.

@dleeapho
Copy link

dleeapho commented Oct 9, 2019

When we do need to rev the targeting pack we'll need to manually enable it.

@dagood dagood self-assigned this Nov 11, 2019
@dagood
Copy link
Member Author

dagood commented Dec 17, 2019

This specific work is done. Followup porting to master is already tracked by https://github.com/dotnet/core-setup/issues/8507, other bugs are filed as followup servicing infra bugs.

@dagood dagood closed this as completed Dec 17, 2019
@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@msftgits msftgits added this to the 3.1 milestone Jan 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants