Add runtime platform deps for .NET 6 #6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
requested review from
danmoseley,
jkotas,
MichaelSimons,
eerhardt,
dleeapho and
rbhanda
jkotas
reviewed
Apr 16, 2021
jkotas
reviewed
Apr 16, 2021
jkotas
reviewed
Apr 16, 2021
jkotas
reviewed
Apr 16, 2021
jkotas
reviewed
Apr 16, 2021
omajid
reviewed
Apr 16, 2021
omajid
reviewed
Apr 16, 2021
omajid
reviewed
Apr 16, 2021
omajid
reviewed
Apr 16, 2021
|
Any further feedback on this from anyone? |
reflectronic
reviewed
May 6, 2021
Since the name expression uses a logical operator, the ID must be set explicitly in order to be referenceable.
@Saiprasad16 - Can you clarify this? Your comment isn't associated with a specific line in the file. |
mthalman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5646
Defines all of .NET's runtime platform dependencies for Linux, Windows, and macOS. This uses the platform dependency schema.
This relies on the RID inheritance model. For example, RHEL and CentOS have the same package dependencies and the
centosRID inherits fromrhel. So in the dependency model, I defined dependencies just for therhelRID which would be implicitly inherited bycentos.I decided not to include any Windows desktop UI packages such as WPF and WinForms because I didn't see much benefit to having them. One of the main reasons for tracking Windows dependencies is to differentiate what libraries exist between the different Windows variants (Windows Server, Windows desktop, Windows Server Core, and Nano Server). Since Windows Server Core and Nano Server are headless, using the desktop UI packages isn't really an option. And the remaining variants, Windows Server and Windows desktop, provide all the necessary dependencies. Based on that, producing an itemized list of what those dependencies are seems like a lot of work without much benefit. We can re-evaluate later if we determine there's a need.
I won't actually merge this until Preview 4 ships.