Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client library for querying .NET platform dependency files #114

Closed
wants to merge 7 commits into from

Conversation

mthalman
Copy link
Member

@mthalman mthalman commented May 4, 2021

This defines a client library project (dotnet/core#5647), to be published as a package, that can consume the platform dependency schema. The proposed model that implements this schema is available at dotnet/core#6170.

The library provides an API to load and validate the model and access all its state.

It also provides higher-level APIs rather than only exposing the raw state of the model. Specifically, it provides a parsed expression representation for dependency names and resolving of dependencies within a platform hierarchy.

@mthalman
Copy link
Member Author

mthalman commented May 4, 2021

@mthalman
Copy link
Member Author

mthalman commented May 4, 2021

The build failures are unrelated to my changes. The same errors occur in main branch. I've logged #115.

Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build infra changes look good. I have not reviewed the library code.

<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>

<PropertyGroup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse my lack of Arcade knowledge. What is this section for and why is TargetsWindows the only property set if this is a cross plat library?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had just copied this from Microsoft.Deployment.DotNet.Releases. I see that clickonce defines things differently. @NikolaMilosavljevic - Where did you get the content for that file and why are the Targets* properties defined differently than it is for Microsoft.Deployment.DotNet.Releases?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikolaMilosavljevic - is all of this necessary?

@MichaelSimons
Copy link
Member

@mthalman - Is this PR still relevant?

@mthalman
Copy link
Member Author

@mthalman - Is this PR still relevant?

😬 No. There's more work needed in the overall design. I'll close this.

@mthalman mthalman closed this Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants