Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database collation is scaffolded as a raw annotation and not with the Fluent API #25418

Closed
roji opened this issue Aug 4, 2021 · 0 comments · Fixed by #25420
Closed

Database collation is scaffolded as a raw annotation and not with the Fluent API #25418

roji opened this issue Aug 4, 2021 · 0 comments · Fixed by #25420
Assignees
@roji
Labels
area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
6.0.0

Comments

@roji
Copy link
Member

roji commented Aug 4, 2021 •
edited
Loading

We currently get:

modelBuilder.HasAnnotation("Relational:Collation", "SQL_Latin1_General_CP1_CI_AS");

... instead of:

modelBuilder.UseCollation("SQL_Latin1_General_CP1_CI_AS");

Raised in #25404
@roji roji self-assigned this Aug 4, 2021
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 4, 2021
@roji roji added this to the 6.0.0 milestone Aug 4, 2021
@roji roji mentioned this issue Aug 4, 2021
Closed
roji added a commit that referenced this issue Aug 4, 2021
@roji
Fixes around scaffolding collations
9f4015e 
* Database-level collation is scaffolded to the Fluent API call,
  instead of to a raw annotation.
* Don't scaffold database collation when it is identical to the
  server collation (i.e. is the default).

Fixes #25418
Fixes #25419
@roji roji mentioned this issue Aug 4, 2021
Merged
roji added a commit that referenced this issue Aug 4, 2021
@roji
Fixes around scaffolding collations
12d3f26 
* Database-level collation is scaffolded to the Fluent API call,
  instead of to a raw annotation.
* Don't scaffold database collation when it is identical to the
  server collation (i.e. is the default).

Fixes #25418
Fixes #25419
roji added a commit that referenced this issue Aug 5, 2021
@roji
Fixes around scaffolding collations (#25420)
1556414 
* Database-level collation is scaffolded to the Fluent API call,
  instead of to a raw annotation.
* Don't scaffold database collation when it is identical to the
  server collation (i.e. is the default).

Fixes #25418
Fixes #25419
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc1 Aug 12, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc1, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fixes around scaffolding collations dotnet/efcore
2 participants
@ajcvickers @roji