Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes around scaffolding collations #25420

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Fixes around scaffolding collations #25420

merged 1 commit into from
Aug 5, 2021

Conversation

roji
Copy link
Member

@roji roji commented Aug 4, 2021 •
edited
Loading

  • Database-level collation is scaffolded to the Fluent API call, instead of to a raw annotation.
  • Don't scaffold database collation when it is identical to the server collation (i.e. is the default).

Fixes #25418
Fixes #25419

Note that we have a test the the database collation isn't scaffolded when it's the default, but no coverage for when it's different, since our DatabaseModelFactoryTest tests don't create new databases. I've manually verified this works.

@roji roji requested a review from a team August 4, 2021 12:02
@roji
Fixes around scaffolding collations
12d3f26 
* Database-level collation is scaffolded to the Fluent API call,
  instead of to a raw annotation.
* Don't scaffold database collation when it is identical to the
  server collation (i.e. is the default).

Fixes #25418
Fixes #25419
@roji roji merged commit 1556414 into main Aug 5, 2021
@roji roji deleted the CollationFixes branch August 5, 2021 07:13
@ajcvickers ajcvickers mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikEJ ErikEJ ErikEJ left review comments

@bricelam bricelam bricelam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@roji @bricelam @ErikEJ