-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--folder option is different in SDK bundled tool vs. mainline #1385
Comments
@JoeRobich, thanks for the info. I am still lost on the why part; was the [*.{cs,vb}]
# Organize usings
dotnet_separate_import_directive_groups = true
dotnet_sort_system_directives_first = true
# IDE0005: Using directive is unnecessary.
# (this does not work with --folder, but it's fine,
# it just gets skipped in a non-fatal manner)
dotnet_diagnostic.IDE0005.severity = warning now with .NET 6 SDK's |
@am11 The default You also got hit by another breaking change, the organize imports formatter was moved from a whitespace formatter to be a style formatter, since it was not whitespace related and was in fact enforcing a code style rule. There has been some discussion about possibly enabling the CC: @jmarolf in case you have any thoughts |
would need to understand if |
Yup, I'm mainly using it for performance because the default, project workspace, takes ages in large projects. 🙂 |
As we're rolling out .NET 6 across our build infrastructure we got burned by this today. We have a repository with over 1700 separate csproj files and around 800 SLN files. All told there's approximately 5.5 million LoC in the repo. To keep the entire repository in line we've been using an automated It doesn't appear that there is any way to replicate the current 5.X folder functionality, as the |
@cliffchapmanrbx i am trying to solve the same issue as well. My current solution is create a custom github action find out what projects are involved in the change and use matrix to run dotnet format targeting those projects separately. I wonder what is your solution in the end? |
…json We're no longer using the separate dotnet-format tool since it is integrated into the dotnet SDK now. With the move to the SDK the options changed a bit so we now need to use the `whitespace` format command so we can continue using the `--folder` option: dotnet/format#1385 To run not just whitespace but code style formatters as well we'd need a workspace context (i.e. pass the .csproj to dotnet format), but inferring that from just the changed file list is hard.
…json (#94839) We're no longer using the separate dotnet-format tool since it is integrated into the dotnet SDK now. With the move to the SDK the options changed a bit so we now need to use the `whitespace` format command so we can continue using the `--folder` option: dotnet/format#1385 To run not just whitespace but code style formatters as well we'd need a workspace context (i.e. pass the .csproj to dotnet format), but inferring that from just the changed file list is hard.
Using the nightly (5 hours old) .NET SDK
6.0.100-rtm.21514.1
with bundled dotnet-format,--folder
option doesn't have any effect.with latest 5x (3 days old) downloaded from nuget.org, we get:
The expected behavior implemented by #790.
Was it intentionally dropped out of .NET 6?
The text was updated successfully, but these errors were encountered: