Fix format.sh script and remove dotnet-format tool from dotnet-tools.json #94839
Conversation
…json We're no longer using the separate dotnet-format tool since it is integrated into the dotnet SDK now. With the move to the SDK the options changed a bit so we now need to use the `whitespace` format command so we can continue using the `--folder` option: dotnet/format#1385 To run not just whitespace but code style formatters as well we'd need a workspace context (i.e. pass the .csproj to dotnet format), but inferring that from just the changed file list is hard.
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsWe're no longer using the separate dotnet-format tool since it is integrated into the dotnet SDK now. With the move to the SDK the options changed a bit so we now need to use the To run not just whitespace but code style formatters as well we'd need a workspace context (i.e. pass the .csproj to dotnet format), but inferring that from just the changed file list is hard.
|
| @@ -17,7 +17,7 @@ fi | |||
|
|
|||
| if [ -n "$MANAGED_FILES" ]; then | |||
| # Format all selected files | |||
| echo "$MANAGED_FILES" | cat | xargs | sed -e 's/ /,/g' | dotnet format --no-restore --include - | |||
| echo "$MANAGED_FILES" | cat | xargs | sed -e 's/ /,/g' | dotnet format whitespace --include - --folder | |||
There was a problem hiding this comment.
Is this script invoked in CI or just a dev innerloop thing?
There was a problem hiding this comment.
Just a dev innerloop thing.
We're no longer using the separate dotnet-format tool since it is integrated into the dotnet SDK now.
With the move to the SDK the options changed a bit so we now need to use the
whitespaceformat command so we can continue using the--folderoption: dotnet/format#1385To run not just whitespace but code style formatters as well we'd need a workspace context (i.e. pass the .csproj to dotnet format), but inferring that from just the changed file list is hard.