Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle |null types when optimizing away equals/hash/compare from LanguagePrimitves into instance method calls #18296

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Handle |null types when optimizing away equals/hash/compare from LanguagePrimitves into instance method calls #18296

merged 5 commits into from
Feb 7, 2025

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Feb 6, 2025

Fixes #18286

@T-Gro T-Gro linked an issue Feb 6, 2025 that may be closed by this pull request
Null reference on equality with nested record #18286
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@T-Gro T-Gro marked this pull request as ready for review February 7, 2025 07:57
@T-Gro T-Gro requested a review from a team as a code owner February 7, 2025 07:57
@psfinaki
Copy link
Member

psfinaki commented Feb 7, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki psfinaki merged commit ee55997 into main Feb 7, 2025
33 checks passed
@T-Gro T-Gro deleted the 18286-null-reference-on-equality-with-nested-record branch February 10, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null reference on equality with nested record
3 participants
@T-Gro @psfinaki @vzarytovskii