[dotnet] Make bundling the 'createdump' utility opt-in. Fixes #16189. (…

…#18960)

Make bundling the 'createdump' utility opt-in by setting BundleCreateDump=true.

Fixes: #16189

dotnet/targets/Xamarin.Shared.Sdk.targets

@@ -1518,7 +1518,7 @@
 				PublishFolderType="Assembly"
 			/>
 			<ResolvedFileToPublish Remove="@(_CreateDumpExecutable)" />
-			<ResolvedFileToPublish Include="@(_CreateDumpExecutable)" />
+			<ResolvedFileToPublish Include="@(_CreateDumpExecutable)" Condition="'$(BundleCreateDump)' == 'true'" />
 
 			<!-- Remove any dylibs Mono told us not to link with -->
 			<ResolvedFileToPublish
@@ -1631,7 +1631,7 @@
 	<Target Name="_ComputeCodesignItems"
 		Outputs="$(_CodesignItemsPath)"
 		>
-		<ItemGroup Condition="'$(_RequireCodeSigning)' == 'true'">
+		<ItemGroup Condition="'$(_RequireCodeSigning)' == 'true' And '$(BundleCreateDump)' == 'true'">
 			<!-- The 'createdump' executable must be signed. -->
 			<!-- Ref: https://github.com/xamarin/xamarin-macios/issues/13417 -->
 			<_CreateDumpExecutableToSign Include="@(_CreateDumpExecutable -> '$(_DylibPublishDir)%(RelativePath)')" KeepMetadata="false">

tests/dotnet/UnitTests/BundleStructureTest.cs

@@ -294,9 +294,6 @@ internal static void CheckAppBundleContents (ApplePlatform platform, IEnumerable
 			AddMultiRidAssembly (platform, expectedFiles, assemblyDirectory, Path.GetFileNameWithoutExtension (Configuration.GetBaseLibraryName (platform, true)), runtimeIdentifiers, forceSingleRid: (platform == ApplePlatform.MacCatalyst && !isReleaseBuild) || platform == ApplePlatform.MacOSX, hasPdb: false, includeDebugFiles: includeDebugFiles);
 			expectedFiles.Add (Path.Combine (assemblyDirectory, "runtimeconfig.bin"));
 
-			if (platform == ApplePlatform.MacOSX)
-				expectedFiles.Add (Path.Combine ("Contents", "MonoBundle", "createdump"));
-
 			switch (platform) {
 			case ApplePlatform.iOS:
 			case ApplePlatform.TVOS:

tests/dotnet/UnitTests/ProjectTest.cs

@@ -635,7 +635,7 @@ public void BuildCoreCLR (ApplePlatform platform, string runtimeIdentifiers)
 			ExecuteWithMagicWordAndAssert (platform, runtimeIdentifiers, appExecutable);
 
 			var createdump = Path.Combine (appPath, "Contents", "MonoBundle", "createdump");
-			Assert.That (createdump, Does.Exist, "createdump existence");
+			Assert.That (createdump, Does.Not.Exist, "createdump existence");
 		}
 
 		[Test]