Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot Restart does not support xcframeworks or binding resource packages #16571

Closed
rolfbjarne opened this issue Nov 3, 2022 · 2 comments · Fixed by #18103
Closed

Hot Restart does not support xcframeworks or binding resource packages #16571

rolfbjarne opened this issue Nov 3, 2022 · 2 comments · Fixed by #18103
Assignees
@rolfbjarne
Labels
binding-projects Issue or PR that affects binding projects bug If an issue is a bug or a pull request a bug fix windows-only The issue only occur on Windows
Milestone
.NET 8

Comments

@rolfbjarne
Copy link
Member

It seems Hot Restart does not support neither xcframeworks nor binding resource packages.

Ref: dotnet/maui#10800 (comment)
Ref: dotnet/maui#10800 (comment)

Note that this is a mirror issue for https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1656382.
@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Nov 3, 2022
@rolfbjarne rolfbjarne added this to the .NET 8 milestone Nov 3, 2022
@rolfbjarne rolfbjarne mentioned this issue Nov 3, 2022
Closed
@mattjohnsonpint mattjohnsonpint mentioned this issue Nov 6, 2022
Closed
@mattjohnsonpint
Copy link

I notice this has been labeled for .NET 8. Should I expect then that the fix won't be released for .NET 6 or 7 then? I need to know, so I can decide whether or not I should include a custom build target in my own nuget package as a workaround in the meantime. Thanks.

@rolfbjarne
Copy link
Member Author

@mattjohnsonpint once it's fixed, we'll decide exactly where to backport it. However, it's certainly not going to be in the initial .NET 7 release (since packages are already public at NuGet.org).

My recommendation would be to include a workaround with your NuGet if that's possible (just make sure that the workaround is compatible with the fix too).

@mattjohnsonpint mattjohnsonpint mentioned this issue Nov 9, 2022
Closed
@rolfbjarne rolfbjarne added the binding-projects Issue or PR that affects binding projects label Dec 19, 2022
@rolfbjarne rolfbjarne self-assigned this Feb 10, 2023
@rolfbjarne rolfbjarne mentioned this issue Feb 28, 2023
Closed
@rolfbjarne rolfbjarne added the windows-only The issue only occur on Windows label Mar 14, 2023
@rolfbjarne rolfbjarne mentioned this issue Apr 24, 2023
Merged
rolfbjarne added a commit that referenced this issue May 3, 2023
@rolfbjarne
[msbuild/tests/dotnet] Add support for xcframeworks for Hot Restart a…
6e7128b 
…nd add tests. Fixes #16571. (#18103)

Rework Hot Restart builds to use as much as possible of the normal build
logic, because this is the easiest way to make sure the Hot Restart build is
as close as possible to normal builds (and we don't end up missing features).

This is done by executing selected parts of a normal build, and at the end we
have a new task that computes where each file goes in the various output
directories Hot Restart uses (HotRestartAppBundlePath, HotRestartContentDir,
HotRestartAppContentDir, etc.)

This PR also:

* Adds a test that runs on Windows and verifies that everything consumed in a
  build is placed in the correct location for a Hot Restart build (this is a
  variation of the BundleStructure test we already have).
* Removes tasks that aren't used anymore.
* Misc fixes to make sure existing code works on Windows.

---

This PR is best reviewed commit-by-commit.

Ref: #13924

* Fixes #16571
* Fixes #16001
* Fixes #10784
* Fixes #17579
* Contributes towards #13924.
@rolfbjarne rolfbjarne mentioned this issue May 8, 2023
Closed
@mattjohnsonpint mattjohnsonpint mentioned this issue May 10, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rolfbjarne rolfbjarne

Labels
binding-projects Issue or PR that affects binding projects bug If an issue is a bug or a pull request a bug fix windows-only The issue only occur on Windows
Projects
None yet
Milestone
.NET 8
2 participants
@rolfbjarne @mattjohnsonpint