Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Make sure to copy the manifest from a binding resource package back to Windows. Fixes #18402. #18419

Merged
merged 1 commit into from
Jun 8, 2023
Merged

[msbuild] Make sure to copy the manifest from a binding resource package back to Windows. Fixes #18402. #18419

merged 1 commit into from
Jun 8, 2023

Conversation

rolfbjarne
Copy link
Member

This fixes a build problem on windows when a project has a project reference
to a binding project. The binding resource package from the binding project
would lack the manifest, and thus the main project wouldn't detect it as a
binding resource package, effectively not seeing any native resource from the
binding project.

Fixes #18402.

@rolfbjarne
[msbuild] Make sure to copy the manifest from a binding resource pack…
7a48210 
…age back to Windows. Fixes dotnet#18402.

This fixes a build problem on windows when a project has a project reference
to a binding project. The binding resource package from the binding project
would lack the manifest, and thus the main project wouldn't detect it as a
binding resource package, effectively not seeing any native resource from the
binding project.

Fixes dotnet#18402.
@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners June 7, 2023 16:28
@rolfbjarne rolfbjarne mentioned this pull request Jun 7, 2023
Closed
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 7a482108012e0cce4ad1809ef5715b5b97bd6790 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 7a482108012e0cce4ad1809ef5715b5b97bd6790 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch: All 35 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 7a482108012e0cce4ad1809ef5715b5b97bd6790 [PR build]

@rolfbjarne rolfbjarne merged commit 707a2db into dotnet:main Jun 8, 2023
@rolfbjarne rolfbjarne deleted the msbuild-copy-manifest-to-windows branch June 8, 2023 14:51
@rolfbjarne
Copy link
Member Author

/sudo backport release/7.0.2xx-xcode14.3

1 similar comment
@rolfbjarne
Copy link
Member Author

/sudo backport release/7.0.2xx-xcode14.3

@rolfbjarne rolfbjarne mentioned this pull request Jun 9, 2023
Merged
rolfbjarne added a commit that referenced this pull request Jun 12, 2023
@rolfbjarne
[release/7.0.2xx-xcode14.3] [msbuild] Make sure to copy the manifest …
d758d68 
…from a binding resource package back to Windows. Fixes #18402. (#18425)

This fixes a build problem on windows when a project has a project reference
to a binding project. The binding resource package from the binding project
would lack the manifest, and thus the main project wouldn't detect it as a
binding resource package, effectively not seeing any native resource from the
binding project.

Fixes #18402.

Backport of #18419.
@rolfbjarne rolfbjarne mentioned this pull request Jan 26, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@emaf emaf emaf approved these changes

@haritha-mohan haritha-mohan haritha-mohan approved these changes

@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to build iOS (.NET 7) Binding Library wrapping iOS Framework Native Reference?
5 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @emaf @haritha-mohan