[release/8.0.1xx-preview6] [msbuild] Fix ILStripping of resource assemblies on Windows. #18526
Conversation
Any assembly that's not already on the Mac must be copied there, so do that. We detect if an assembly exist on the Mac by checking the file size of the file on Windows: a 0-length file is an output file from an assembly that exist on the Mac, otherwise it doesn't and must be copied. Fixes dotnet#17009. Fixes dotnet#14841. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1817898.
vs-mobiletools-engineering-service2
requested review from
emaf,
mauroa and
rolfbjarne
as code owners
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)
✅ API diff vs stable.NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 91 tests passed. Failures❌ dotnettests tests [attempt 3]
Html Report (VSDrops) Download Successes
Pipeline on Agent |
Any assembly that's not already on the Mac must be copied there, so do that.
We detect if an assembly exist on the Mac by checking the file size of the
file on Windows: a 0-length file is an output file from an assembly that exist
on the Mac, otherwise it doesn't and must be copied.
Fixes #17009.
Fixes #14841.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1817898.
Backport of #18508