Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILStrip failed for ... resources.dll' not found #17009

Closed
GioviQ opened this issue Dec 10, 2022 · 8 comments · Fixed by #18508
Closed

ILStrip failed for ... resources.dll' not found #17009

GioviQ opened this issue Dec 10, 2022 · 8 comments · Fixed by #18508
Labels
bug If an issue is a bug or a pull request a bug fix
Milestone
.NET 8

Comments

@GioviQ
Copy link

GioviQ commented Dec 10, 2022

I experience the same issue as #13922

Differences

MAUI net7.0-ios

Visual Studio 17.4.2
@rolfbjarne
Copy link
Member

Please attach a binary build log we can use to diagnose this, since #13922 is fixed and you're probably running into something different (although it looks the same).

@rolfbjarne rolfbjarne added the need-info Waiting for more information before the bug can be investigated label Dec 12, 2022
@ghost
Copy link

ghost commented Dec 12, 2022

Hi @GioviQ. We have added the "need-info" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@GioviQ
Copy link
Author

GioviQ commented Dec 12, 2022

MSBuild_Logs.zip
2022-12-12_13-46-13.15944.Ide.log

here it is

@ghost ghost added need-attention An issue requires our attention/response and removed need-info Waiting for more information before the bug can be investigated labels Dec 12, 2022
@rolfbjarne
Copy link
Member

Thanks!

For future self: the binlog named CentralNode_devenv_PID=15944_x64_BuildManager_Unnamed_9.binlog shows the error.

This is probably the underlying reason (note that the it subdirectory got lost):

[ILStrip] obj/Release/net7.0-ios/ios-arm64/it/QRCodeGenerator.resources.dll to obj/Release/net7.0-ios/ios-arm64//stripped/QRCodeGenerator.resources.dll

This the input item:

obj\Release\net7.0-ios\ios-arm64\it\QRCodeGenerator.resources.dll
    CopyToPublishDirectory = PreserveNewest
    Culture = it
    OutputPath = obj/Release/net7.0-ios/ios-arm64//stripped/QRCodeGenerator.resources.dll
    PublishFolderType = Assembly
    RelativePath = ..\QRCodeGenerator.app\\it\QRCodeGenerator.resources.dll
    TargetPath = it\QRCodeGenerator.resources.dll

I'm guessing we'll have to take TargetPath into account here:

https://github.com/xamarin/xamarin-macios/blob/1db1f4869812a693c753f8c40a341b84e0525e0e/dotnet/targets/Xamarin.Shared.Sdk.targets#L743-L746

@rolfbjarne rolfbjarne added bug If an issue is a bug or a pull request a bug fix and removed need-attention An issue requires our attention/response labels Dec 12, 2022
@rolfbjarne rolfbjarne added this to the .NET 8 milestone Dec 12, 2022
@GioviQ
Copy link
Author

GioviQ commented Dec 12, 2022

In the meanwhile how can I publish?

@rolfbjarne
Copy link
Member

@GioviQ adding this to your project file should do it:

<PropertyGroup>
    <EnableAssemblyILStripping>false</EnableAssemblyILStripping>
</PropertyGroup>

@rolfbjarne
Copy link
Member

rolfbjarne commented Dec 19, 2022 •
edited
Loading

This might be a dup of #14841.

@rolfbjarne rolfbjarne mentioned this issue Jan 16, 2023
Closed
@yrest
Copy link

yrest commented Mar 24, 2023

Just hit the same on 17.5.3, which among other issues adds to frustration. :(

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Jun 28, 2023
@rolfbjarne
[msbuild] Fix ILStripping of resource assemblies on Windows.
5727bef 
Any assembly that's not already on the Mac must be copied there, so do that.
We detect if an assembly exist on the Mac by checking the file size of the
file on Windows: a 0-length file is an output file from an assembly that exist
on the Mac, otherwise it doesn't and must be copied.

Fixes dotnet#17009.
Fixes dotnet#14841.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1817898.
@rolfbjarne rolfbjarne mentioned this issue Jun 28, 2023
Merged
rolfbjarne added a commit that referenced this issue Jun 29, 2023
@rolfbjarne
[msbuild] Fix ILStripping of resource assemblies on Windows. (#18508)
c7fa7ab 
Any assembly that's not already on the Mac must be copied there, so do that.
We detect if an assembly exist on the Mac by checking the file size of the
file on Windows: a 0-length file is an output file from an assembly that exist
on the Mac, otherwise it doesn't and must be copied.

Fixes #17009.
Fixes #14841.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1817898.
@rolfbjarne rolfbjarne mentioned this issue Jun 29, 2023
Merged
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Jun 29, 2023
@rolfbjarne
[release/7.0.3xx] [msbuild] Fix ILStripping of resource assemblies on…
7e27252 
… Windows.

Any assembly that's not already on the Mac must be copied there, so do that.
We detect if an assembly exist on the Mac by checking the file size of the
file on Windows: a 0-length file is an output file from an assembly that exist
on the Mac, otherwise it doesn't and must be copied.

Fixes dotnet#17009.
Fixes dotnet#14841.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1817898.

Backport of dotnet#18508.
dalexsoto pushed a commit that referenced this issue Jun 30, 2023
@rolfbjarne
[release/7.0.3xx] [msbuild] Fix ILStripping of resource assemblies on…
43ae6c7 
… Windows. (#18511)

Any assembly that's not already on the Mac must be copied there, so do
that.
We detect if an assembly exist on the Mac by checking the file size of
the
file on Windows: a 0-length file is an output file from an assembly that
exist
on the Mac, otherwise it doesn't and must be copied.

Fixes #17009.
Fixes #14841.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1817898.

Backport of #18508.
Closed
vs-mobiletools-engineering-service2 pushed a commit to vs-mobiletools-engineering-service2/xamarin-macios that referenced this issue Jun 30, 2023
@rolfbjarne
[msbuild] Fix ILStripping of resource assemblies on Windows.
c8158cf 
Any assembly that's not already on the Mac must be copied there, so do that.
We detect if an assembly exist on the Mac by checking the file size of the
file on Windows: a 0-length file is an output file from an assembly that exist
on the Mac, otherwise it doesn't and must be copied.

Fixes dotnet#17009.
Fixes dotnet#14841.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1817898.
@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug If an issue is a bug or a pull request a bug fix
Projects
None yet
Milestone
.NET 8
Development

Successfully merging a pull request may close this issue.

[msbuild] Fix ILStripping of resource assemblies on Windows. rolfbjarne/xamarin-macios
3 participants
@rolfbjarne @GioviQ @yrest