Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xcode16.3] Merge main into xcode16.3. #22248

Merged
merged 19 commits into from
Mar 3, 2025

Conversation

rolfbjarne
Copy link
Member

No description provided.

rolfbjarne and others added 9 commits February 24, 2025 09:49
This has to be done in parts, because the Roslyn importer runs out of
memory otherwise.

Which also means I have no idea how many parts there will end up being.

Partial fix for #17399.
This changes does two things:

1. Adds a GetValue internal helper for non value backend smart enums.
2. Uses the GetValue functions as the builder for the NSArray.

The new method (1) is only added to those smart enums that use a none
value type backing field that looks like the following:

```csharp
internal static ASAuthorizationProviderAuthorizationOperation GetValue (NativeHandle handle)
{
  using var str = Runtime.GetNSObject<NSString> (handle);
  return GetValue (str);
}
```

This is later used to retrieve the enum values from the handle in a
BindAs decorated method/property. This is very similar to what we did in
#22216 and has the same
performance considerations (there is no performance change after C# 11
and later).

---------

Co-authored-by: GitHub Actions Autoformatter <[email protected]>
…2246)

When building in CI, check that the platform is included in the env
variable to build the API definitions dll.
We do not longer support them in dotnet so we remove the support from
bgen and update the tests to use the CoreGraphics alternatives.

If a user adds any of the remove types they will get an exception with
an unboxing error.
* Allow for specifying a local path to the analyzer assemblies.
* Update the api availability test using locally built analyzers that includes
  dotnet/roslyn-analyzers#7569, because the public analyzers
  have a bug we run into *a lot*.
* Write more values in GeneratedMSBuildEditorConfig.editorconfig. This is be required
  in newer versions of the platform availability analyzer.
rolfbjarne and others added 5 commits February 26, 2025 20:06
…22233)

Improve listing older tooling workloads we might depend on by not hardcoding version numbers.

Ref: dotnet/maui#27318
This pull request updates the following dependencies

## Coherency Updates

The following updates ensure that dependencies with a *CoherentParentDependency*
attribute were produced in a build used as input to the parent dependency's build.
See [Dependency Description Format](https://github.com/dotnet/arcade/blob/master/Documentation/DependencyDescriptionFormat.md#dependency-description-overview)

- **Coherency Updates**:
  - **Microsoft.NET.ILLink.Tasks**: from 9.0.1 to 9.0.2 (parent: Microsoft.NET.Sdk)
  - **Microsoft.AspNetCore.App.Ref**: from 9.0.1 to 9.0.2 (parent: Microsoft.NET.Sdk)
  - **Microsoft.NETCore.App.Ref**: from 9.0.1 to 9.0.2 (parent: Microsoft.NET.Sdk)
  - **Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport**: from 9.0.1-servicing.24604.3 to 9.0.2-servicing.25061.2 (parent: Microsoft.NETCore.App.Ref)
  - **Microsoft.NETCore.App.Ref**: from 9.0.1 to 9.0.2 (parent: Microsoft.NET.Sdk)
  - **Microsoft.DotNet.Cecil**: from 0.11.5-alpha.24602.1 to 0.11.5-alpha.25056.3 (parent: Microsoft.NETCore.App.Ref)

## From https://github.com/dotnet/sdk

- **Subscription**: a3af34df-ee86-4a08-b10d-b90bd4a87d76
- **Build**: 20250211.36
- **Date Produced**: February 12, 2025 2:32:17 AM UTC
- **Commit**: 346d06baea1cf7113e181e779b056b955973c633
- **Branch**: refs/heads/release/9.0.1xx

- **Updates**:
  - **Microsoft.NET.Sdk**: [from 9.0.103-servicing.25065.25 to 9.0.104-servicing.25111.36][1]
  - **Microsoft.NET.ILLink.Tasks**: [from 9.0.1 to 9.0.2][2]
  - **Microsoft.AspNetCore.App.Ref**: [from 9.0.1 to 9.0.2][3]
  - **Microsoft.NETCore.App.Ref**: [from 9.0.1 to 9.0.2][2]
  - **Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport**: [from 9.0.1-servicing.24604.3 to 9.0.2-servicing.25061.2][4]
  - **Microsoft.NETCore.App.Ref**: [from 9.0.1 to 9.0.2][2]
  - **Microsoft.DotNet.Cecil**: [from 0.11.5-alpha.24602.1 to 0.11.5-alpha.25056.3][5]

[1]: dotnet/sdk@049799c...346d06b
[2]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GCc8acea22626efab11c13778c028975acdc34678f&targetVersion=GC80aa709f5d919c6814726788dc6dabe23e79e672&_a=files
[3]: https://dev.azure.com/dnceng/internal/_git/dotnet-aspnetcore/branches?baseVersion=GC4442a188f9200a57635373dcd640893c0e8dcc78&targetVersion=GC704f7cb1d2cea33afb00c2097731216f121c2c73&_a=files
[4]: dotnet/emsdk@4c9d1b1...2c27e40
[5]: dotnet/cecil@72791f7...7ea2381
#22252)

* Add missing availability attributes for .NET.
* Remove !.NET availability attributes / code.

This is a step towards fixing #21185.
@dalexsoto
Copy link
Member

/azp run xamarin-macios-pr,xamarin-macios-apidiff

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

This has to be done in parts, because the Roslyn importer runs out of
memory otherwise.

Which also means I have no idea how many parts there will end up being.

Partial fix for #17399.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #67138bb] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 67138bb43b1dc903b31951e73ba77ba14941e86b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #67138bb] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 67138bb43b1dc903b31951e73ba77ba14941e86b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #67138bb] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 67138bb43b1dc903b31951e73ba77ba14941e86b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #67138bb] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 67138bb43b1dc903b31951e73ba77ba14941e86b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #67138bb] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 67138bb43b1dc903b31951e73ba77ba14941e86b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #67138bb] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 67138bb43b1dc903b31951e73ba77ba14941e86b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #67138bb] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 67138bb43b1dc903b31951e73ba77ba14941e86b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) Unable to create gist: Response status code does not indicate success: 422 (Unprocessable Entity). (raw diff) - Please review changes)

Pipeline on Agent
Hash: 67138bb43b1dc903b31951e73ba77ba14941e86b [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #67138bb] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

2 tests crashed, 5 tests failed, 95 tests passed.

Failures

❌ dotnettests tests (iOS) [attempt 2]

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (MacCatalyst) [attempt 2]

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (macOS) [attempt 2]

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (tvOS)

🔥 Failed catastrophically on VSTS: test results - dotnettests_tvos (no summary found).

Html Report (VSDrops) Download

❌ introspection tests [attempt 2]

1 tests failed, 0 tests passed.

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

🔥 Failed catastrophically on VSTS: test results - monotouch_ios (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests (tvOS) [attempt 2]

1 tests failed, 7 tests passed.
  • monotouch-test/tvOS - simulator/Release (NativeAOT, x64): Failed

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 67138bb43b1dc903b31951e73ba77ba14941e86b [PR build]

@rolfbjarne
Copy link
Member Author

Test failures are unrelated (just teething problems with the xcode16.3 branch, and will be fixed in separate PRs).

@rolfbjarne rolfbjarne merged commit 8640425 into xcode16.3 Mar 3, 2025
37 of 46 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/bump-main-in-xcode16.3-2025-02-26 branch March 3, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants