Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move most controls to use ModifyMapping (and variants) #15058

Closed
wants to merge 110 commits into from
Closed

Move most controls to use ModifyMapping (and variants) #15058

wants to merge 110 commits into from

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented May 12, 2023 •
edited
Loading

Description of Change

This PR makes most of the controls use the mapper modifiers as opposed to replacing the entire mapper reference.

Part of the fix for #11662 and part of PR #13836

This PR is worth getting in first to really mark this moment in history:

Dependencies

  1. Use [AppendTo|PrependTo|Replace]Mapping for Focus commands #15040
  2. Use PrependToMapping method to replace Window MapTitle method #15041
  3. Ensure "text boxes" preserve cursor location #15099
  4. Implement all permutations of InputTransparent and CascadeInputTransparent #14846
  5. Text needs to be set before other properties #16116

mattleibow added 30 commits April 29, 2023 20:46
@mattleibow
Fix InputTransparent and CascadeInputTransparent
2ce285c
@mattleibow
Adding some tests for the baseline
1895907
@mattleibow
Merge branch 'dev/input-transparent' into dev/input-transparency
86bf05d
@mattleibow
This works better
802dc6e
@mattleibow
Fix this
063147c
@mattleibow
Also these platforms
77de113
@mattleibow
Support compatibility
1224014
@mattleibow
Merge remote-tracking branch 'origin/main' into dev/input-transparency
36691d5
@mattleibow
Merge remote-tracking branch 'origin/main' into dev/input-transparency
172a95e
@mattleibow
Merge remote-tracking branch 'origin/main' into dev/input-transparency
61fa09f
@mattleibow
Merge remote-tracking branch 'origin/main' into dev/input-transparency
36aca2b
@mattleibow
Improved the sample for testing
c69dabd
@mattleibow
Merge remote-tracking branch 'origin/main' into dev/input-transparency
454de2f
@mattleibow
Merge remote-tracking branch 'origin/main' into dev/input-transparency
f83b9f8
@mattleibow
See what this does
9609697
@mattleibow
Revert "See what this does"
38213d6 
This reverts commit 9609697.
@mattleibow
Merge remote-tracking branch 'origin/main' into dev/input-transparency
d695531
@mattleibow
comment out new tests
e5ac916
@mattleibow
Merge remote-tracking branch 'origin/main' into dev/input-transparency
27366b9
@mattleibow
Try reverting these
31bfb34
@mattleibow
Revert "Try reverting these"
c7887a7 
This reverts commit 31bfb34.
@mattleibow
Revert the bad code hacks
5a6b8f0
@mattleibow
This should work!
944f048
@mattleibow
Merge remote-tracking branch 'origin/main' into dev/input-transparency
c1705c6
@mattleibow
Use AppendToMapping for Focus commands
c9c218f
@mattleibow
Use new PrependToMapping method
d5730f7
@mattleibow
this
792bf74
@mattleibow
The entire method is replaced
41fac60
@mattleibow
Merge remote-tracking branch 'origin/main' into dev/input-transparency
8572262
@mattleibow
Skip the failing test for now
bb9adac
@mattleibow
Merge branch 'main' into dev/more-mappers
949fd13 
# Conflicts:
#	src/Controls/src/Core/Layout/Layout.Android.cs
#	src/Controls/src/Core/Layout/Layout.Mapper.cs
#	src/Controls/src/Core/Layout/Layout.Tizen.cs
#	src/Controls/src/Core/Layout/Layout.Windows.cs
#	src/Controls/src/Core/Layout/Layout.iOS.cs
#	src/Controls/src/Core/Platform/iOS/Extensions/TextExtensions.cs
#	src/Controls/src/Core/SearchBar/SearchBar.Mapper.cs
#	src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.cs
@mattleibow mattleibow changed the title Move some controls to use ModifyMapping Move most controls to use ModifyMapping (and variants) Jul 10, 2023
@mattleibow mattleibow marked this pull request as ready for review July 10, 2023 12:55
@mattleibow mattleibow mentioned this pull request Jul 10, 2023
Closed
This was referenced Jul 10, 2023
Closed
Merged
@samhouts samhouts added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 20, 2023
@mattleibow
Copy link
Member Author

mattleibow commented Jul 23, 2023 •
edited
Loading

#13836 has these changes and more.

@mattleibow mattleibow closed this Jul 23, 2023
@MartyIX
Copy link
Contributor

MartyIX commented Jul 23, 2023

(Probably #13836 was meant.)

@mattleibow
Copy link
Member Author

yeah, thanks!

@mattleibow mattleibow deleted the dev/more-mappers branch July 24, 2023 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
@Eilon Eilon added area-controls-general General issues that span multiple controls, or common base classes such as View or Element and removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-controls-general General issues that span multiple controls, or common base classes such as View or Element
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattleibow @MartyIX @Eilon @samhouts