Android has issues with Entry #16077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
legacy-area-controls
This was referenced Jul 10, 2023
|
I will fix this correctly. |
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
It appears that setting
EditText.InputTypewill trigger theTextChangedevent. This could - and does - happen in #15058 when we no longer chain the mappers forcing theTextmapper to always run first.The reason the order matters for us is that
EditTextis a generic text input control and the default mode is actually multiline. We remove the multiline support forEntryand this will always require setting theInputType. However, this is really a very short term solution as other things touch that property:IsPassword,Keyboard,IsReadOnlyand even spell check things. As a result, we would have to move all those thing to happen after the text is set.The simplest is to reorder the keys so that
Textis the very first. When theInputTypeis set later, and thus triggering theTextChangedevent, the platform view already has the text and thus the text change is updated.After that PR lands, the order is really based on the order in the
EntryHandlerin Core. This PR will fix it for that PR so thatTextis first and then everyone is happy.