-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Maui Blazor Desktop #2526
Merged
LoopedBard3
merged 38 commits into
dotnet:release/6.0
from
LoopedBard3:MauiBlazorDesktopQuickFix
Aug 8, 2022
Merged
Add Maui Blazor Desktop #2526
LoopedBard3
merged 38 commits into
dotnet:release/6.0
from
LoopedBard3:MauiBlazorDesktopQuickFix
Aug 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#1) * First working iteration of MauiBlazor WinUI startup with inner startup time capturing. This mostly consisted of adding a new parser that looks for the FirstRender event from overridden blazor, and adding that to the startup path. * Apply suggestions from code review Co-authored-by: Tanay Parikh <[email protected]>
…ing going on there causing the failure.
…lass not being done correctly.
…don't hit webview problem.
…ricSource, and add in a first render if statement for the source adder to add the event after.
TanayParikh
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for putting this together!
Co-authored-by: Tanay Parikh <[email protected]>
…tements to fall in line with the rest of the printing infra we use.
TanayParikh
approved these changes
Aug 6, 2022
LoopedBard3
added a commit
to LoopedBard3/performance
that referenced
this pull request
Aug 9, 2022
* Add `mauiblazordesktop` scenario * Add WinUIBlazor startup parser * Update release/6.0 to use dotnet version 6.0.4xx
LoopedBard3
added a commit
that referenced
this pull request
Aug 19, 2022
* First iteration of maui desktop changes/support Add platform. Add the WinUI Parser and WinUI Metric type. Change WinUI test to use the WinUI startup metric and removed self contained from pre.py. Still need to figure out the exact way that the WindowsAppSDK will be installed/supported with the app. Add the installation of the newer windowsappsdk. Cleaned up pre.py command code. Add maui desktop scenario to scenarios for testing while figuring out final format. Only run winui on windows. * Add Maui Blazor Desktop (#2526) * Add `mauiblazordesktop` scenario * Add WinUIBlazor startup parser * Update release/6.0 to use dotnet version 6.0.4xx * Reformat mauidesktop test.py to more closely match release/6.0 and remove comment from pre.py. * Update blazor to use net7 rollback file. * Update desktop blazor maui scenario to use PERFLAB_Framework instead of just _Framework for the target framework. * Move the windows condition up to minimize duplicate places that it is and move the Maui blazor desktop work items into the same group as the default windows desktop ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.