C# needs real unit/void support #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davkean
changed the title
jmarolf
approved these changes
Oct 11, 2018
drewnoakes
approved these changes
Oct 11, 2018
| @@ -71,6 +108,30 @@ protected Task ExecuteUnderLockAsync(Func<CancellationToken, Task> action, Cance | |||
| return ExecuteUnderLockCoreAsync(action, cancellationToken); | |||
| } | |||
|
|
|||
| private async Task<T> ExecuteUnderLockCoreAsync<T>(Func<CancellationToken, Task<T>> action, CancellationToken cancellationToken = default) | |||
| { | |||
| Requires.NotNull(action, nameof(action)); | |||
There was a problem hiding this comment.
Callers already check this. Can remove one or the other.
| @@ -71,6 +108,30 @@ protected Task ExecuteUnderLockAsync(Func<CancellationToken, Task> action, Cance | |||
| return ExecuteUnderLockCoreAsync(action, cancellationToken); | |||
There was a problem hiding this comment.
Looks like you could merge the two ExecuteUnderLockCoreAsync methods, keeping only the generic Task<T> overload and passing a lambda here that produces an ignored return value. Would that introduce significant overhead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Task overloads for downstream consumers (latter PR)