Merge IActiveWorkspaceProjectContextHost and IWorkspaceProjectContextHost #4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Host This moves all consumers of the old language service APIs over to the new APIs and shims the old language service under them.
davkean
changed the title
davidwengier
approved these changes
Oct 11, 2018
drewnoakes
approved these changes
Oct 12, 2018
|
@drewnoakes Possibly but at the moment that's going to result in an explosion of overloads, I'll let the dust settle on the design before I plumb through that. |
|
@dotnet-bot retest windows_release please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes #4102 so only review ce49d0f.
This moves all consumers of the old language service APIs over to the new APIs and shims the old language service under them.