-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add linux CI #4444
add linux CI #4444
Conversation
a2353ad
to
5443b2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4444 +/- ##
==========================================
- Coverage 95.85% 95.84% -0.02%
==========================================
Files 1179 1182 +3
Lines 268733 268752 +19
Branches 16224 16226 +2
==========================================
- Hits 257607 257575 -32
- Misses 9062 9104 +42
- Partials 2064 2073 +9 |
@mavasani looking at the test results it appears e have some tests that rely on windows style paths |
Fixing some hardcoded windows paths makes the tests run work much better for me: diff --git a/src/Test.Utilities/CSharpCodeFixVerifier`2+Test.cs b/src/Test.Utilities/CSharpCodeFixVerifier`2+Test.cs
index 23b6ec5e4..f8d221d5a 100644
--- a/src/Test.Utilities/CSharpCodeFixVerifier`2+Test.cs
+++ b/src/Test.Utilities/CSharpCodeFixVerifier`2+Test.cs
@@ -55,7 +55,7 @@ public Test()
DocumentId.CreateNewId(projectId, debugName: ".editorconfig"),
".editorconfig",
SourceText.From($"is_global = true" + Environment.NewLine + AnalyzerConfigDocument),
- filePath: @"z:\.editorconfig");
+ filePath: @"/tmp/.editorconfig");
}
return solution;
diff --git a/src/Test.Utilities/VisualBasicCodeFixVerifier`2+Test.cs b/src/Test.Utilities/VisualBasicCodeFixVerifier`2+Test.cs
index 6c0074678..1c76fcd64 100644
--- a/src/Test.Utilities/VisualBasicCodeFixVerifier`2+Test.cs
+++ b/src/Test.Utilities/VisualBasicCodeFixVerifier`2+Test.cs
@@ -33,7 +33,7 @@ public Test()
DocumentId.CreateNewId(projectId, debugName: ".editorconfig"),
".editorconfig",
SourceText.From($"is_global = true" + Environment.NewLine + AnalyzerConfigDocument),
- filePath: @"z:\.editorconfig");
+ filePath: @"/tmp/.editorconfig");
}
return solution; The paths should be conditionalized correctly based on OS. Another set of failures is based on assuming the newlines in the file are always diff --git a/src/PublicApiAnalyzers/UnitTests/DeclarePublicApiAnalyzerTests.cs b/src/PublicApiAnalyzers/UnitTests/DeclarePublicApiAnalyzerTests.cs
index 6b943c43e..191b4014e 100644
--- a/src/PublicApiAnalyzers/UnitTests/DeclarePublicApiAnalyzerTests.cs
+++ b/src/PublicApiAnalyzers/UnitTests/DeclarePublicApiAnalyzerTests.cs
@@ -2094,6 +2094,8 @@ public class {|RS0016:{|RS0016:C2|}|} { }
[InlineData("\r\n\r\n", "\r\n")]
public async Task TestPreserveTrailingNewline(string originalEndOfFile, string expectedEndOfFile)
{
+ originalEndOfFile = originalEndOfFile.Replace("\r\n", Environment.NewLine, StringComparison.Ordinal);
+ expectedEndOfFile = expectedEndOfFile.Replace("\r\n", Environment.NewLine, StringComparison.Ordinal);
var source = @"
public class C
{ |
...ers/UnitTests/Microsoft.CodeQuality.Analyzers/Maintainability/ReviewUnusedParametersTests.cs
Outdated
Show resolved
Hide resolved
ea39dba
to
f832c7f
Compare
...itTests/Microsoft.NetCore.Analyzers/Security/UseDefaultDllImportSearchPathsAttributeTests.cs
Outdated
Show resolved
Hide resolved
@jmarolf Are you blocked here? |
28b3100
to
8e8bc64
Compare
e05eb97
to
fd67909
Compare
No description provided.