-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit all tests that require WindowsOnlyFact
or WindowsOnlyTheory
and make them work on linux
#4586
Comments
WindowsOnlyFact
and make them work on linuxWindowsOnlyFact
or `WindowsOnlyTheory
and make them work on linux
WindowsOnlyFact
or `WindowsOnlyTheory
and make them work on linuxWindowsOnlyFact
or WindowsOnlyTheory
and make them work on linux
These tests are failing intermittently on newly added Unix queues. dotnet#4586 tracks fixing and enabling these tests on these queues.
The failing test for ReleaseTrackingAnalyzer seems like a product bug (not a critical one though). The fix isn't using consistent line endings. The following constants are using '\r\n': Lines 28 to 32 in b148fa8
But then, Note: There are "hacky" ways to make tests path without changing in the fixer itself. This shouldn't be done claiming to fix the issue. |
Interestingly, release tracking test doesn't actually fail on Linux builds. I was expecting them to fail due to my previous reasoning 😕. |
the
WindowsOnlyFact
andWindowsOnlyTheory
attributes was applied to several tests in #4444 to unblock merging. We should audit the remaining tests and figure out how to enable them again on linux.The text was updated successfully, but these errors were encountered: