Normalize multiline descriptions to \n in sarif files

[Youssef1313]

Fixes #4587

cc: @Evangelink

[sharwell]

Can we enable the tool in Linux builds again? Should be a good indicator of whether we fixed all the cases.

[Youssef1313]

Can we enable the tool in Linux builds again? Should be a good indicator of whether we fixed all the cases.

Ah yes. I forgot. That's the main goal of the PR 😄

[jmarolf]

as @sharwell says, If you can remove all the uses of WindowsOnlyFact I'll sign off

[Youssef1313]

as @sharwell says, If you can remove all the uses of WindowsOnlyFact I'll sign off

That's a different issue tracked by #4586. I'm planning to look into it, but maybe should be in a different PR

[jmarolf]

ah, right you are

[codecov]

Codecov Report

Merging #4783 (6c242a2) into master (da9973b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4783   +/-   ##
=======================================
  Coverage   95.67%   95.68%           
=======================================
  Files        1193     1193           
  Lines      271525   271525           
  Branches    16413    16413           
=======================================
+ Hits       259795   259802    +7     
  Misses       9620     9620           
+ Partials     2110     2103    -7