Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows-only tests #4785

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Feb 5, 2021

Fixing part of #4586.

@Youssef1313 Youssef1313 changed the title Draft Draft: Fix Windows-only tests Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #4785 (169ba3d) into master (da9973b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4785   +/-   ##
=======================================
  Coverage   95.67%   95.68%           
=======================================
  Files        1193     1193           
  Lines      271525   271570   +45     
  Branches    16413    16416    +3     
=======================================
+ Hits       259795   259841   +46     
  Misses       9620     9620           
+ Partials     2110     2109    -1     

@Youssef1313
Copy link
Member Author

Closing/re-opening to re-trigger CI failure:

dotnet-install: Downloading primary link https://dotnetcli.azureedge.net/dotnet/Sdk/5.0.100/dotnet-sdk-5.0.100-linux-x64.tar.gz
/datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh: line 908: http_code: unbound variable
Failed to install dotnet SDK from public location (exit code '1').
##[error](NETCORE_ENGINEERING_TELEMETRY=InitializeToolset) Failed to install dotnet SDK from public location (exit code '1').

@Youssef1313 Youssef1313 closed this Feb 5, 2021
@Youssef1313 Youssef1313 reopened this Feb 5, 2021
@Youssef1313
Copy link
Member Author

Youssef1313 commented Feb 5, 2021

Closing/re-opening to re-trigger CI failure:

dotnet-install: Downloading primary link https://dotnetcli.azureedge.net/dotnet/Sdk/5.0.100/dotnet-sdk-5.0.100-linux-x64.tar.gz
/datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh: line 908: http_code: unbound variable
Failed to install dotnet SDK from public location (exit code '1').
##[error](NETCORE_ENGINEERING_TELEMETRY=InitializeToolset) Failed to install dotnet SDK from public location (exit code '1').

Sounds like consistent failure. @jmarolf @mavasani Any idea what's causing this? (Found it - dotnet/install-scripts#136)

@Youssef1313 Youssef1313 closed this Feb 5, 2021
@Youssef1313 Youssef1313 reopened this Feb 5, 2021
@Youssef1313 Youssef1313 marked this pull request as ready for review February 5, 2021 21:28
@Youssef1313 Youssef1313 requested a review from a team as a code owner February 5, 2021 21:28
@Youssef1313 Youssef1313 changed the title Draft: Fix Windows-only tests Fix Windows-only tests Feb 5, 2021
@mavasani mavasani merged commit ea2e171 into dotnet:master Feb 16, 2021
@Youssef1313 Youssef1313 deleted the fix-win-only-tests branch February 16, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants