Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSharpErrorListDesktop.ErrorLevelWarning test and related are flakey #18996

Closed
VSadov opened this issue Apr 26, 2017 · 5 comments
Closed

CSharpErrorListDesktop.ErrorLevelWarning test and related are flakey #18996

VSadov opened this issue Apr 26, 2017 · 5 comments
Assignees
@sharwell
Labels
Area-External Disabled Test Test Test failures in roslyn-CI
Milestone
Backlog

Comments

@VSadov
Copy link
Member

VSadov commented Apr 26, 2017

Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpErrorListNetCore.ErrorList
Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpErrorListNetCore.ErrorLevelWarning
Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpErrorListDesktop.ErrorList
Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpErrorListDesktop.ErrorLevelWarning
VSadov added a commit to VSadov/roslyn that referenced this issue Apr 26, 2017
@VSadov
Disabling tests due to flakiness
0719a06 
 dotnet#18996

Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpErrorListNetCore.ErrorList
Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpErrorListNetCore.ErrorLevelWarning
Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpErrorListDesktop.ErrorList
Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpErrorListDesktop.ErrorLevelWarning
@VSadov VSadov mentioned this issue Apr 26, 2017
Merged
@sharwell
Copy link
Member

sharwell commented Apr 28, 2017 •
edited
Loading

I'm a bit concerned that these tests are telling us about a real race condition bug in our product. Running the integration tests locally I'm occasionally able to observe this behavior, but nothing close to tracking it down so far.

@Pilchie
Copy link
Member

Pilchie commented Apr 28, 2017

@srivatsn @jmarolf these are the ones you just disabled and entered a bug on project-system for, right?

@jmarolf
Copy link
Contributor

jmarolf commented Apr 29, 2017

This is actually a different set of tests than the one I set a PR out for, but if you asking if this should also be in the project system repo, I would say yes as the intent is the same

@srivatsn srivatsn mentioned this issue May 4, 2017
Closed
@srivatsn
Copy link
Contributor

srivatsn commented May 4, 2017

This issue was moved to dotnet/project-system#2125

@srivatsn srivatsn closed this as completed May 4, 2017
@sharwell sharwell mentioned this issue Mar 1, 2018
Merged
@sharwell sharwell self-assigned this Mar 1, 2018
@sharwell sharwell added the 4 - In Review A fix for the issue is submitted for review. label Mar 1, 2018
@sharwell sharwell added this to the 15.7 milestone Mar 1, 2018
@sharwell
Copy link
Member

sharwell commented Mar 1, 2018

@srivatsn Reopening this because the tests still exist in Roslyn, and are un-skipped as part of the work in #25151. Please review the approach and let me know if this is good or we need to do something else.

@sharwell sharwell reopened this Mar 1, 2018
@jinujoseph jinujoseph added Test Test failures in roslyn-CI and removed 4 - In Review A fix for the issue is submitted for review. labels Apr 18, 2018
@jinujoseph jinujoseph modified the milestones: 15.7, 15.8 Apr 24, 2018
@jinujoseph jinujoseph modified the milestones: 15.8, Unknown Jun 3, 2018
sharwell added a commit to sharwell/roslyn that referenced this issue Jan 3, 2019
@sharwell
Fix .NET Core project tests
675adf0 
Closes dotnet#18996
Closes dotnet#19090
Closes dotnet#19091
@sharwell sharwell mentioned this issue Jan 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-External Disabled Test Test Test failures in roslyn-CI
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@srivatsn @Pilchie @sharwell @VSadov @jmarolf @jinujoseph