Fix .NET Core project tests #32122
Merged
Fix .NET Core project tests #32122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes dotnet#18996 Closes dotnet#19090 Closes dotnet#19091
Integration tests now ignore error list entries not associated with a project, since these entries should have been cleared when the solution closed. This workaround should be removed when dotnet#32121 is resolved.
mavasani
approved these changes
Jan 3, 2019
| @@ -32,73 +32,145 @@ public void WaitForNoErrorsInErrorList() | |||
|
|
|||
| public void NavigateToErrorListItem(int itemIndex) | |||
| { | |||
| var errorItems = GetErrorItems().AsEnumerable(); | |||
| var errorItems = GetErrorItems().AsEnumerable().ToArray(); | |||
| if (itemIndex > errorItems.Count()) | |||
There was a problem hiding this comment.
Nit: Don't need to use linq here or below for count. I thought we had an analyzer to catch these..
There was a problem hiding this comment.
Agree, but I'm fine with leaving this so we can move the PR forward more efficiently and it's only test code.
|
|
||
| public static string GetFileName(this IVsTaskItem item) | ||
| { | ||
| ErrorHandler.ThrowOnFailure(item.Document(out var fileName)); |
There was a problem hiding this comment.
Does this return an empty string for error list items without document name?
There was a problem hiding this comment.
I'm not sure. It's the pattern I used in the test harness experiment and it worked for all the tests we have today. We can always adjust it if we need to test a new scenario and we haven't completed the switch to Apex yet.
| => ExecuteCommand(WellKnownCommandNames.ProjectAndSolutionContextMenus_Solution_RestoreNuGetPackages); | ||
| public bool RestoreNuGetPackages(string projectName) | ||
| { | ||
| var solutionRestoreService = InvokeOnUIThread(() => GetComponentModel().GetExtensions<IVsSolutionRestoreService2>().Single()); |
|
@jaredpar for approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18996
Closes #19090
Closes #19091
Implements a workaround for #32121.