Features/unmanaged constructed types #32704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add unmanaged generic struct tests * Don't bail out of managed type checks when type arguments are present * Simplify test * Delegate HasPointerType to underlying field in WrappedFieldSymbol * Add test for recursive expansion of struct with T : unmanaged * Delay constraint checking on field types until after type members are added * Update comment * Add expected diagnostic to UnmanagedRecursiveTypeArgument test * Add unmanaged recursive type argument tests with constraint violations * Don't search fields whose type is circular struct when determining if a type is managed * Update some tests * Use TypeSyntax.Location for Type.CheckAllConstraints * Add prototype comment * Update GenericConstraintsTests * Update IsManagedType asserts in UnsafeTests * Fix ManagedAddressOfTests.DisallowSizeof * Use SourceMemberFieldSymbol.SyntaxNode.Location for consistency in diagnostics * Add some tests and diagnostics * Fix more tests * Fix BaseClassTests * Add test for partially constructed generic struct which violates unmanaged constraint * Consider nullability when running AfterTypeMembersChecks * Update NullableReferenceTypesTests.Constraint_Oblivious due to differences from delayed constraint checks on field types * Check if NRT enabled in compilation to use correct nullability in constraint checks * Make UnmanagedConstraint_StructMismatchInImplements behave consistently * Disable ResourceTests.AddResourceToModule in Mono * Remove prototype comment * Remove invalid comments from UnmanagedConstraints_NestedInGenericType * Use ErrorLocation instead of SyntaxNode.Location * Rename our pipeline YAML files Originally created when everything was VSTS. This gets us back inline with the new branding. * Fix tests now that we use ErrorLocation for field constraint checks
Merge master to unmanaged constructed type feature branch
…ed on feature checks as needed.
…anaged type argument
Fixed a bug in constraint checking where the wrong Compilation would be used.
…s-testing Unmanaged constructed types tests
…s/unmanaged-constructed-types
…cted-types Merge dev16.1-preview1 into features/unmanaged-constructed-types
* Test generic struct with private field from metadata * Expand generic ref struct testing * Reference generic unmanaged tuple issue in relevant tests * Add fixed size buffer tests * Add IsManagedType checks in test cases involving circular structs * Verify that unsafe scenarios disallowed in 7.3 are allowed latest * Test IsManagedType API in more recursive scenarios
…s/unmanaged-constructed-types
…cted-types Merge dev16.1-preview1 into features/unmanaged-constructed-types
jaredpar
approved these changes
Jan 23, 2019
|
CC. @jkotas, who was interested in the feature as well. It should allow some amount of code to be simplified (once we have a compiler CoreFX/CoreCLR can consume). |
4 tasks
xoofx
pushed a commit
to stark-lang/stark-roslyn
that referenced
this pull request
Apr 16, 2019
…ucted-types Features/unmanaged constructed types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/csharplang#1744 and #31374
This merges the unmanaged constructed types feature into
dev16.1-preview1. @jaredpar approval is required. All of this code has been previously reviewed before being merged into thedotnet/features/unmanaged-constructed-typesbranch.It's worth noting that this implementation allows taking a pointer to a generic ref struct, because taking a pointer to a non-generic ref struct is already allowed. @agocke @gafter so you're aware as this came up in the test plan review.