Merge dev16.1-preview1 into features/unmanaged-constructed-types #32448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move CI / PR triggers to YAML files
Update build, debug, test doc
This changes our build so that it publishes our NuPkg files on PR and CI builds. This enables both us to inspect our artifacts when debugging failures as well as other services, like sharplab, to download them without having to go through the trouble of building them themselves.
Cache the return values for GetIdForErrorCode
Random code comment typo fixes
Fixed adding attribute list with target specifier
…ember Rename an enum member to be clearer, and add docs as well.
EditorFeatures.Text IVTs for MonoDevelop
Consistently parse .editorconfig option values containing spaces
…otnet#31782) * Fix additional newlines being added when adding all missing imports * Use syntax formatter to remove extra newlines when adding missing imports * Apply suggestions from code review * Added assert to ensure we retain the final newline * Updated the assert to include cases where a newline pre-existed
…#32005) For each reference that doesn't have an .XML doc file we allocate and cache a FileBasedXmlDocumentationProvider that throws a first-chance exception upon first use. Add and use a singleton NullXmlDocumentationProvider instead when the requested .XML doc file doesn't exist.
…onArmOperation (dotnet#32018) - Adds further IOperation nodes for recursive patterns: IDiscardPatternOperation, ISwitchExpressionOperation, ISwitchExpressionArmOperation - Follow-up to dotnet#31967 per dotnet#32012 - Issue dotnet#32012 also describes additional open issues to be addressed later. - Update compiler test plan. - Also revert some changes accidentally checked in to the patterns branch.
…et/roslyn into rpatterns-mergeQ
Merge master into features/recursive-patterns
Closes dotnet#18996 Closes dotnet#19090 Closes dotnet#19091
Integration tests now ignore error list entries not associated with a project, since these entries should have been cleared when the solution closed. This workaround should be removed when dotnet#32121 is resolved.
RikkiGibson
force-pushed
the
features/unmanaged-constructed-types
branch
from
39f1fa3 to
df244d4
Compare
Disable a few tests on Mono
…ching-bugs Finish the project context implementation for the free-threaded project system shims
RikkiGibson
force-pushed
the
features/unmanaged-constructed-types
branch
from
df244d4 to
138a3b9
Compare
Fix assert in UsePatternMatching.CSharpAsAndNullCheckDiagnosticAnalyzer
* Arcade SDK 1.0.0-beta.19054.11 * Consolidate OptProf scripts * Use raw IBC data from VSTS drop
…ster-to-dev16.1-preview1
…preview1 Merge master to dev16.1-preview1
…o-master Merge dev16.0-preview2 to master
…preview1 Merge master to dev16.1-preview1
Fix UseExpressionBodyHelper.GetDiagnosticLocation for indexer declara…
…preview1 Merge master to dev16.1-preview1
…s/unmanaged-constructed-types
RikkiGibson
force-pushed
the
features/unmanaged-constructed-types
branch
from
138a3b9 to
cf5336e
Compare
RikkiGibson
commented
Jan 15, 2019
| @@ -3094,13 +3096,15 @@ class C<T> | |||
| // sbyte, byte, short, ushort, int, uint, long, ulong, char, float, double, decimal, or bool. | |||
| // Any enum_type. | |||
| // Any pointer_type. | |||
| // Any user-defined struct_type that is not a constructed type and contains fields of unmanaged_types only. | |||
| // Any user-defined struct_type that contains fields of unmanaged_types only. | |||
There was a problem hiding this comment.
@agocke should I send a PR to csharplang to update the spec language over there?
RikkiGibson
force-pushed
the
features/unmanaged-constructed-types
branch
from
43d80a9 to
e9addf6
Compare
RikkiGibson
force-pushed
the
features/unmanaged-constructed-types
branch
from
e9addf6 to
86f0984
Compare
jcouv
approved these changes
Jan 16, 2019
|
is a second review needed here? |
|
No need for a second review. The code merge was straightforward and tests don't need two reviews. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the large number of force pushes. Goofed up a few times getting the manual fixups consolidated into one commit.
Please review commit 86f0984.