-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Signature - Add parameter #38748
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinujoseph
added
Area-IDE
PR For Personal Review Only
The PR doesn’t require anyone other than the developer to review it.
labels
Sep 24, 2019
ivanbasov
force-pushed
the
AddParameter
branch
from
October 14, 2019 21:50
56ef465
to
a8d6f44
Compare
ivanbasov
force-pushed
the
AddParameter
branch
from
December 6, 2019 20:34
c24a146
to
15ca623
Compare
ivanbasov
force-pushed
the
AddParameter
branch
from
December 17, 2019 01:38
05310eb
to
b2563be
Compare
Literally just the button, nothing happens when you click it. However, the button is accessible and INPC unit tested.
And feed it back into the grid
This was referenced Mar 23, 2020
This was referenced Mar 24, 2020
CyrusNajmabadi
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the existing Change Signature dialog to allow for the adding of a required parameter (in addition to the existing reorder/remove capabilities). Optional parameters will come as a later update.
The updated Change Signature dialog includes the new "Add" button, as well as two new columns in the datagrid. The "Index" column shows which parameters are new, as well as the original index of preexisting parameters. The "Call site" column shows what value will be put into call sites for this new parameter.
And here is the new Add Parameter dialog itself:
The first two fields both have completion enabled.
TODO for this PR:
Name
field shouldn't have completion (in VB only)Pre-Dogfood:
16.6P1:
Remove/Reorder Parameters
toChange Signature
[work with editor]