Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Signature - Add parameter #38748

Merged
merged 224 commits into from
Mar 26, 2020
Merged

Change Signature - Add parameter #38748

merged 224 commits into from
Mar 26, 2020

Conversation

ivanbasov
Copy link
Contributor

@ivanbasov ivanbasov commented Sep 18, 2019

Updates the existing Change Signature dialog to allow for the adding of a required parameter (in addition to the existing reorder/remove capabilities). Optional parameters will come as a later update.

The updated Change Signature dialog includes the new "Add" button, as well as two new columns in the datagrid. The "Index" column shows which parameters are new, as well as the original index of preexisting parameters. The "Call site" column shows what value will be put into call sites for this new parameter.

image

And here is the new Add Parameter dialog itself:

image

The first two fields both have completion enabled.

TODO for this PR:

  • Manual test pass [D & M]
  • UI
    • VB support [A]
      • Preview
      • Name field shouldn't have completion (in VB only)
    • Design of completion list text boxes [I+J]
    • UX Review
    • Accessibility [D]
      • Add Parameter dialog
      • Change Signature dialog updates
  • Engine
    • Update engine for required parameters (C# & VB) [I]
    • Hook up the simple "TODO" case
  • Most Tests
    • Fix broken unit tests [I]
    • Add new engine unit tests [I]
      • C# unit tests
        • Similar to reorder tests
        • Similar to reorder cascading tests
        • Formatting tests
        • Delegates tests
      • VB unit tests

Pre-Dogfood:

  • UI
    • Backspacing too much crashes [D] -- PR to Editor pending
  • Further testing
    • Unit testing of elision buffer creation
    • Update integration tests [A]
    • Add UI unit tests (when supporting optional parameters) [D]
  • Optional Parameters (Larger UI + Engine updates)
  • Engine
    • Type binding in all contexts, Expand/Reduce namespace/imports (?)

16.6P1:

  • UI
    • Consider the C# UI bug when filling out name before type [A]
    • Meet UX expectations
  • Change VS menu from Remove/Reorder Parameters to Change Signature [work with editor]
  • Engine
    • Handle multiple TODOs

@ivanbasov ivanbasov requested a review from dpoeschl September 18, 2019 18:44
@ivanbasov ivanbasov requested a review from a team as a code owner September 18, 2019 18:44
@jinujoseph jinujoseph added Area-IDE PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. labels Sep 24, 2019
@dpoeschl
Copy link
Contributor

dpoeschl commented Mar 9, 2020

This review is tooooooo big. If you want to offer further comments, please see these new separated reviews:

Product Code: #42291
Test Code: #42290

@dpoeschl dpoeschl merged this pull request into dotnet:master Mar 26, 2020
@ghost ghost modified the milestones: 16.6, Next Mar 26, 2020
@sharwell sharwell modified the milestones: Next, temp, 16.6.P3 Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Feature Request IDE-CodeStyle Built-in analyzers, fixes, and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants