Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Signature - Add parameter #38748

Merged
merged 224 commits into from
Mar 26, 2020
Merged
Changes from 1 commit
Commits
Show all changes
224 commits
Select commit Hold shift + click to select a range
87df86e
Change Signature -- Add a Edit button
dpoeschl Mar 11, 2019
4fe3dab
Change Signature - Add readonly Parameter Details dialog
dpoeschl Mar 11, 2019
7db9a8d
Change Edit Parameter dialog to Add Parameter dialog
dpoeschl Mar 19, 2019
d193e92
Hook up callsite column
dpoeschl Mar 19, 2019
c4b69d6
Add callsite column header
dpoeschl Mar 19, 2019
ab512f5
WIP
dpoeschl Mar 19, 2019
2da815e
progress
dpoeschl Mar 20, 2019
e541d8b
Add index column
dpoeschl Mar 20, 2019
d69225a
Kinda working for regular parameter/argument lists
dpoeschl Mar 21, 2019
a89d771
Allow opening showing change signature for parameterless methods
ivanbasov Oct 29, 2019
82dd2f1
rename CoolParameter -> ParameterBase -> Parameter
ivanbasov Oct 29, 2019
6831f7f
draft of binding add parameters with editor - not working
ivanbasov Nov 5, 2019
12b023c
more binding attempts
ivanbasov Nov 6, 2019
8a4b128
form alignment. host control
ivanbasov Nov 12, 2019
d556f1f
draft of completion support for types (excluding user control files)
ivanbasov Nov 26, 2019
3477238
prototype of binding without controls
ivanbasov Dec 5, 2019
175d6ce
intermediate cleanup
ivanbasov Dec 6, 2019
d65d8a0
intellisense control
ivanbasov Dec 6, 2019
ad4abd8
unit test fix
ivanbasov Dec 6, 2019
40616c8
moving handler into control
ivanbasov Dec 6, 2019
3abdf42
minor ui improvement
ivanbasov Dec 6, 2019
ad5cff2
intellisense for the type name started working
ivanbasov Dec 10, 2019
4b08340
more business logic
ivanbasov Dec 10, 2019
ced272a
extracting intellisense control services
ivanbasov Dec 11, 2019
7cc728c
intellisense support for type and name
ivanbasov Dec 12, 2019
08f8524
dialog ui update
ivanbasov Dec 14, 2019
00d97a0
change signature dialog update to support adding parameters
ivanbasov Dec 17, 2019
20220f6
minor updates
ivanbasov Jan 2, 2020
706419b
Redo Add Parameter dialog layout.
dpoeschl Dec 18, 2019
b9102ab
Send failure notification if Add Parameter dialog incomplete
dpoeschl Dec 18, 2019
f0ff683
Remove a bad/unnecessary import
dpoeschl Dec 18, 2019
490c452
Changed UI (made Add higher) and fixed bug with callsites
allisonchou Dec 20, 2019
9b9182f
make containers non-focusable
ivanbasov Jan 3, 2020
a73c096
extending test infrastructure to support added parameters
ivanbasov Jan 3, 2020
2b05e96
Basic VB implementation. Intellisense doesn't really work yet
allisonchou Jan 3, 2020
b9b3e69
Merge branch 'AddParameter' of https://github.com/ivanbasov/roslyn in…
allisonchou Jan 3, 2020
94b0123
fix test infrastructure
ivanbasov Jan 3, 2020
f07ea36
fixing VB tests
ivanbasov Jan 3, 2020
5fdfc33
existing change signature service tests fixed
ivanbasov Jan 3, 2020
2ab2573
some tests for AddParameter
ivanbasov Jan 4, 2020
9e83034
Merge branch 'master' into AddParameter
ivanbasov Jan 4, 2020
cac5915
VB intellisense
allisonchou Jan 5, 2020
2185fc7
Implement TrySubmit and remove TODOs from ChangeSignatureViewModelTests
dpoeschl Jan 3, 2020
c19935d
Show notification when signature has not been changed.
dpoeschl Jan 6, 2020
3876389
Move string to resource
dpoeschl Jan 6, 2020
077ed7d
Fix TestChangeSignature_AllowedWithNoParameters
dpoeschl Jan 6, 2020
76d38c9
Clean up from rebase
dpoeschl Jan 6, 2020
46a130d
Fix up xlf files
dpoeschl Jan 6, 2020
ece16f4
Use a "+" instead of "NEW" in the index column
dpoeschl Jan 6, 2020
f4eb915
VB implementation -> need to fix crash and find better way to disable…
allisonchou Jan 7, 2020
eda5830
Add new files
allisonchou Jan 7, 2020
2ac434a
Add parameter service unit tests
ivanbasov Jan 7, 2020
0891da2
Remove unused textbox
dpoeschl Jan 6, 2020
996922b
Small changes
allisonchou Jan 7, 2020
6191854
Trying to figure out crash bug
allisonchou Jan 8, 2020
e8aa166
more unit tests
ivanbasov Jan 8, 2020
7084be3
AddParameter dialog layout
dpoeschl Jan 9, 2020
240d8b0
Loc AddParameter and label the textboxes for accessibility
dpoeschl Jan 9, 2020
f8a0b28
Fix name conflict
dpoeschl Jan 9, 2020
7b0c9c0
ChangeSignature grid, use "<new>" and "<TODO>" texts
dpoeschl Jan 9, 2020
867b105
Loc "<new>" and "<TODO>"
dpoeschl Jan 9, 2020
8a7f58d
Separate parameter short & full automation text
dpoeschl Jan 9, 2020
c817d30
Fixup
dpoeschl Jan 9, 2020
024684c
Improve narrator strings for parameters
dpoeschl Jan 9, 2020
8225152
Fix Add Parameter dialog strings
dpoeschl Jan 10, 2020
181569a
engine unit tests
ivanbasov Jan 10, 2020
5a1604c
Give a name to the CallsiteValueTextBox
dpoeschl Jan 10, 2020
672f483
Forgot to add a file.
allisonchou Jan 10, 2020
9ef7cb8
Resolved merge conflicts
allisonchou Jan 10, 2020
2b4b434
Removed some changes
allisonchou Jan 10, 2020
c1b7f4c
Disallow spaces in name field
allisonchou Jan 10, 2020
230f31d
Complete comment
allisonchou Jan 10, 2020
4277d62
Restricted user input and fixed VB delegate bug.
allisonchou Jan 12, 2020
8478f63
Make IntellisenseTextBox LabeledBy work
dpoeschl Jan 12, 2020
60ecc6e
self code review
ivanbasov Jan 13, 2020
1d26fc4
supporitng tests scenarios with no parameters in the original configu…
ivanbasov Jan 15, 2020
dbea534
Change Signature -- Add a Edit button
dpoeschl Mar 11, 2019
3579d01
Change Signature - Add readonly Parameter Details dialog
dpoeschl Mar 11, 2019
8c3537e
Change Edit Parameter dialog to Add Parameter dialog
dpoeschl Mar 19, 2019
a741550
Hook up callsite column
dpoeschl Mar 19, 2019
d1a9985
Add callsite column header
dpoeschl Mar 19, 2019
66b7ec0
WIP
dpoeschl Mar 19, 2019
2e4dba0
progress
dpoeschl Mar 20, 2019
98db4c2
Add index column
dpoeschl Mar 20, 2019
2450428
Kinda working for regular parameter/argument lists
dpoeschl Mar 21, 2019
d993613
Allow opening showing change signature for parameterless methods
ivanbasov Oct 29, 2019
fb63206
rename CoolParameter -> ParameterBase -> Parameter
ivanbasov Oct 29, 2019
579b8fd
draft of binding add parameters with editor - not working
ivanbasov Nov 5, 2019
02422ab
more binding attempts
ivanbasov Nov 6, 2019
2d9dfa9
form alignment. host control
ivanbasov Nov 12, 2019
aa38480
draft of completion support for types (excluding user control files)
ivanbasov Nov 26, 2019
797e487
prototype of binding without controls
ivanbasov Dec 5, 2019
3e00101
intermediate cleanup
ivanbasov Dec 6, 2019
dee8b07
intellisense control
ivanbasov Dec 6, 2019
1e991d6
unit test fix
ivanbasov Dec 6, 2019
60ba56f
moving handler into control
ivanbasov Dec 6, 2019
566ad91
minor ui improvement
ivanbasov Dec 6, 2019
c3b3e1f
intellisense for the type name started working
ivanbasov Dec 10, 2019
0e2b763
more business logic
ivanbasov Dec 10, 2019
4046bdc
extracting intellisense control services
ivanbasov Dec 11, 2019
d7d6371
intellisense support for type and name
ivanbasov Dec 12, 2019
ac3ea6e
dialog ui update
ivanbasov Dec 14, 2019
7cb050d
change signature dialog update to support adding parameters
ivanbasov Dec 17, 2019
ec644c2
minor updates
ivanbasov Jan 2, 2020
b07ea1c
Redo Add Parameter dialog layout.
dpoeschl Dec 18, 2019
be3b231
Send failure notification if Add Parameter dialog incomplete
dpoeschl Dec 18, 2019
684008c
Remove a bad/unnecessary import
dpoeschl Dec 18, 2019
7d15682
Changed UI (made Add higher) and fixed bug with callsites
allisonchou Dec 20, 2019
3d1477e
make containers non-focusable
ivanbasov Jan 3, 2020
c2f4102
extending test infrastructure to support added parameters
ivanbasov Jan 3, 2020
d6f6eaa
Basic VB implementation. Intellisense doesn't really work yet
allisonchou Jan 3, 2020
2174eee
fix test infrastructure
ivanbasov Jan 3, 2020
9732132
fixing VB tests
ivanbasov Jan 3, 2020
9b9b671
existing change signature service tests fixed
ivanbasov Jan 3, 2020
cf3bef8
some tests for AddParameter
ivanbasov Jan 4, 2020
e3fc0ac
VB intellisense
allisonchou Jan 5, 2020
d1f3b38
Implement TrySubmit and remove TODOs from ChangeSignatureViewModelTests
dpoeschl Jan 3, 2020
004996f
Show notification when signature has not been changed.
dpoeschl Jan 6, 2020
7c6ffda
Move string to resource
dpoeschl Jan 6, 2020
5381016
Fix TestChangeSignature_AllowedWithNoParameters
dpoeschl Jan 6, 2020
9370548
Clean up from rebase
dpoeschl Jan 6, 2020
94e5ead
Fix up xlf files
dpoeschl Jan 6, 2020
918d8e9
Use a "+" instead of "NEW" in the index column
dpoeschl Jan 6, 2020
75f5fe1
VB implementation -> need to fix crash and find better way to disable…
allisonchou Jan 7, 2020
add8b2e
Add new files
allisonchou Jan 7, 2020
8602bbf
Add parameter service unit tests
ivanbasov Jan 7, 2020
2c9bfb5
Remove unused textbox
dpoeschl Jan 6, 2020
18d68aa
Small changes
allisonchou Jan 7, 2020
c67f9d7
more unit tests
ivanbasov Jan 8, 2020
5d76abd
AddParameter dialog layout
dpoeschl Jan 9, 2020
6165b4b
Loc AddParameter and label the textboxes for accessibility
dpoeschl Jan 9, 2020
257521f
Fix name conflict
dpoeschl Jan 9, 2020
9700aa3
ChangeSignature grid, use "<new>" and "<TODO>" texts
dpoeschl Jan 9, 2020
2ee402a
Loc "<new>" and "<TODO>"
dpoeschl Jan 9, 2020
39565ca
Separate parameter short & full automation text
dpoeschl Jan 9, 2020
a3b5f35
Fixup
dpoeschl Jan 9, 2020
cf28b74
Improve narrator strings for parameters
dpoeschl Jan 9, 2020
3c6accb
Fix Add Parameter dialog strings
dpoeschl Jan 10, 2020
a1de13f
engine unit tests
ivanbasov Jan 10, 2020
7b580ff
Give a name to the CallsiteValueTextBox
dpoeschl Jan 10, 2020
31e546b
Forgot to add a file.
allisonchou Jan 10, 2020
7f4d5bf
Disallow spaces in name field
allisonchou Jan 10, 2020
c6a3847
Complete comment
allisonchou Jan 10, 2020
2d8664d
Restricted user input and fixed VB delegate bug.
allisonchou Jan 12, 2020
be0b351
Make IntellisenseTextBox LabeledBy work
dpoeschl Jan 12, 2020
c03706f
self code review
ivanbasov Jan 13, 2020
82394f4
supporitng tests scenarios with no parameters in the original configu…
ivanbasov Jan 15, 2020
ffc6153
merge conflict resolution
ivanbasov Jan 16, 2020
271a846
Added integration tests
allisonchou Jan 16, 2020
e6ac858
fixing delegate and parameterless tests
ivanbasov Jan 16, 2020
230fa69
Apply suggestions from code review
ivanbasov Jan 16, 2020
80efd56
Apply suggestions from code review
ivanbasov Jan 16, 2020
00ef3ab
resolve suggestions
ivanbasov Jan 16, 2020
e43efce
more suggestion fixes
ivanbasov Jan 16, 2020
2097011
Fixed merge conflicts
allisonchou Jan 16, 2020
77985c1
code review feedback partiall addressed
ivanbasov Jan 17, 2020
592bfb2
Made callsite label show up again
allisonchou Jan 17, 2020
bd50d0e
Merge branch 'AddParameter' of https://github.com/ivanbasov/roslyn in…
allisonchou Jan 17, 2020
7107e96
Save CallSiteValue to the viewmodel (so it's not always <TODO>)
dpoeschl Jan 17, 2020
a16983e
Change "<TODO>" to just "TODO", and fix "Call site value" label
dpoeschl Jan 17, 2020
81190f8
Merge conflict changes
allisonchou Jan 17, 2020
ff4ae16
Delete line
allisonchou Jan 17, 2020
9274f14
Temporarily delete VB integration test since it isn't working
allisonchou Jan 17, 2020
2bd36f5
addressing code review feedback
ivanbasov Jan 18, 2020
2a6dd82
merge
ivanbasov Jan 18, 2020
d0306f1
more fixes
ivanbasov Jan 18, 2020
b475c24
Fixed VB ordering #41059
allisonchou Jan 18, 2020
e908036
Merge branch 'AddParameter' of https://github.com/ivanbasov/roslyn in…
allisonchou Jan 18, 2020
75d1d39
Forgot a semicolon
allisonchou Jan 21, 2020
472523e
fixing unit tests
ivanbasov Jan 21, 2020
4435cee
Merge branch 'AddParameter' of https://github.com/ivanbasov/roslyn in…
ivanbasov Jan 21, 2020
644e4c4
Fix parameter name binding in Change Signature Dialog
dpoeschl Jan 21, 2020
844515f
fixing tests for insertPosition
ivanbasov Jan 21, 2020
197a1fd
TryGetInsertPositionFromDeclaration simplification
ivanbasov Jan 21, 2020
1316fcd
Merge branch 'master' into AddParameter
ivanbasov Jan 21, 2020
a921603
more cr feedback
ivanbasov Jan 21, 2020
2760086
Merge branch 'AddParameter' of https://github.com/ivanbasov/roslyn in…
ivanbasov Jan 21, 2020
86942e0
merge conflict resolution
ivanbasov Jan 21, 2020
cadbc0c
fixing tests
ivanbasov Jan 21, 2020
b4d53eb
more cr feedback
ivanbasov Jan 22, 2020
723b78a
Fixed VB tests
allisonchou Jan 22, 2020
a83b445
Integration test fix
allisonchou Jan 22, 2020
4770444
more code review feedback
ivanbasov Jan 23, 2020
cac0215
Merge branch 'AddParameter' of https://github.com/ivanbasov/roslyn in…
ivanbasov Jan 23, 2020
2012d2a
VB intellisense bug fix
allisonchou Jan 23, 2020
1727e45
Merge branch 'AddParameter' of https://github.com/ivanbasov/roslyn in…
allisonchou Jan 23, 2020
b9d1e62
more code review feedback
ivanbasov Jan 23, 2020
3ba7b6e
Merge branch 'AddParameter' of https://github.com/ivanbasov/roslyn in…
allisonchou Jan 23, 2020
0fe1e7f
VB intellisense bug fix
allisonchou Jan 23, 2020
016a740
code review feedback. iteration 1. complete
ivanbasov Jan 23, 2020
d5a3a36
Merge branch 'AddParameter' of https://github.com/ivanbasov/roslyn in…
allisonchou Jan 23, 2020
b7a28c2
refactor IChangeSignatureOptionsService #41145
ivanbasov Jan 24, 2020
fd7f76a
Merge branch 'AddParameter' of https://github.com/ivanbasov/roslyn in…
allisonchou Jan 24, 2020
86f8802
Fixed cross language bug and added more integration tests
allisonchou Jan 24, 2020
e5408ba
Disable intellisense for type field when name field is typed first
allisonchou Jan 24, 2020
72811e1
refactor: moving from syntaxfactory to syntaxgenerator
ivanbasov Jan 25, 2020
a9a8b06
Store added parameter type symbolically and add usings where needed
dpoeschl Feb 5, 2020
e7069bc
Update unit test shape
dpoeschl Feb 5, 2020
04e7a53
Fix broken tests
dpoeschl Feb 5, 2020
9af3651
Tests for adding usings
dpoeschl Feb 5, 2020
2c358ad
Fixup a test helper
dpoeschl Feb 5, 2020
4588ac3
Cascading test with adding imports
dpoeschl Feb 5, 2020
2742dc6
VB Add Parameter Add Imports test
dpoeschl Feb 5, 2020
20e16b9
Merge pull request #41396 from dotnet/merges/master-to-release/dev16.…
Feb 5, 2020
23f38a6
Merge remote-tracking branch 'dotnet/release/dev16.6-preview1' into A…
dpoeschl Feb 5, 2020
c1b234b
Merge fixups, it builds now
dpoeschl Feb 5, 2020
98a2412
Merge fixup - remove unneeded test
dpoeschl Feb 5, 2020
b44c950
Merge remote-tracking branch 'dotnet/master' into AddParameterIvan
dpoeschl Feb 19, 2020
f7f8fd6
Merge remote-tracking branch 'dotnet/master' into AddParameterIvan
dpoeschl Feb 20, 2020
b364e9b
Merge remote-tracking branch 'dotnet/master' into AddParameterIvan
dpoeschl Feb 25, 2020
fec34e2
Merge remote-tracking branch 'dotnet/master' into AddParameterIvan
dpoeschl Mar 20, 2020
42cb80f
Resource file changes
dpoeschl Mar 20, 2020
843b1ab
Fix copyright
dpoeschl Mar 20, 2020
6a4cde8
Merge cleanup
dpoeschl Mar 20, 2020
d029f48
Suppress some nullability warnings
dpoeschl Mar 20, 2020
70edba7
Return null instead of default
dpoeschl Mar 20, 2020
da79c96
Fix copyrights
dpoeschl Mar 20, 2020
2ee577c
Fix copyright
dpoeschl Mar 20, 2020
1fa146d
Merge fixups
dpoeschl Mar 20, 2020
c3a5bce
Use regular textboxes without completion
dpoeschl Mar 22, 2020
f9eb976
Clean up grid columns
dpoeschl Mar 22, 2020
64295fa
Fix integration tests
dpoeschl Mar 22, 2020
2ee46dc
Remove IntelliSenseTextBox
dpoeschl Mar 22, 2020
9a65d8e
Remove invalid usings to fix the build
dpoeschl Mar 23, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Change Signature -- Add a Edit button
Literally just the button, nothing happens when you click it. However, the button is accessible and INPC unit tested.
dpoeschl authored and ivanbasov committed Jan 2, 2020
commit 87df86eb5941c8a8a66db8a75bd5ed56d3b4c72d
Original file line number Diff line number Diff line change
@@ -9,8 +9,8 @@
xmlns:imagecatalog="clr-namespace:Microsoft.VisualStudio.Imaging;assembly=Microsoft.VisualStudio.ImageCatalog"
xmlns:vs="clr-namespace:Microsoft.VisualStudio.PlatformUI;assembly=Microsoft.VisualStudio.Shell.15.0"
xmlns:imagingPlatformUI="clr-namespace:Microsoft.VisualStudio.PlatformUI;assembly=Microsoft.VisualStudio.Imaging"
Height="420" Width="560"
MinHeight="420" MinWidth="560"
Height="470" Width="560"
MinHeight="470" MinWidth="560"
Title="{Binding ElementName=dialog, Path=ChangeSignatureDialogTitle}"
HasHelpButton="True"
ResizeMode="CanResizeWithGrip"
@@ -61,7 +61,7 @@
<TextBlock Grid.Row="0" Height="Auto" Width="Auto" Padding="0,4,0,0" Text="{Binding ElementName=dialog, Path=Parameters}"/>
<Grid Grid.Row="1">
<Grid.RowDefinitions>
<RowDefinition MinHeight="180"/>
<RowDefinition MinHeight="220"/>
<RowDefinition Height="Auto"/>
<RowDefinition Height="Auto"/>
</Grid.RowDefinitions>
@@ -285,6 +285,15 @@
AutomationProperties.Name="{Binding RestoreAutomationText}"
Content="{Binding ElementName=dialog, Path=Restore}"
Height="Auto" Width="Auto"/>

<vs:DialogButton
Margin="9 29 0 0"
IsEnabled="{Binding CanEdit, Mode=OneWay}"
AutomationProperties.Name="{Binding EditAutomationText}"
Click="Edit_Click"
AutomationProperties.AutomationId="EditButton"
Content="{Binding ElementName=dialog, Path=Edit}"
Height="Auto" Width="Auto"/>
</StackPanel>
</Grid>

Original file line number Diff line number Diff line change
@@ -23,6 +23,7 @@ internal partial class ChangeSignatureDialog : DialogWindow
public string PreviewReferenceChanges { get { return ServicesVSResources.Preview_reference_changes; } }
public string Remove { get { return ServicesVSResources.Re_move; } }
public string Restore { get { return ServicesVSResources.Restore; } }
public string Edit { get { return ServicesVSResources.Edit; } }
public string OK { get { return ServicesVSResources.OK; } }
public string Cancel { get { return ServicesVSResources.Cancel; } }

@@ -125,6 +126,16 @@ private void Restore_Click(object sender, RoutedEventArgs e)
SetFocusToSelectedRow();
}

private void Edit_Click(object sender, RoutedEventArgs e)
{
if (_viewModel.CanEdit)
{
// TODO
}

SetFocusToSelectedRow();
}

private void SetFocusToSelectedRow()
{
if (Members.SelectedIndex >= 0)
Original file line number Diff line number Diff line change
@@ -122,22 +122,46 @@ public bool CanRestore
}
}

public bool CanEdit
{
get
{
if (!SelectedIndex.HasValue)
{
return false;
}

// Cannot edit `this` parameter
var index = SelectedIndex.Value;
if (index == 0 && _thisParameter != null)
{
return false;
}

// Cannot edit params parameter
if (index >= (_thisParameter == null ? 0 : 1) + _parameterGroup1.Count + _parameterGroup2.Count)
{
return false;
}

return !AllParameters[SelectedIndex.Value].IsRemoved;
}
}

internal void Remove()
{
AllParameters[_selectedIndex.Value].IsRemoved = true;
NotifyPropertyChanged(nameof(AllParameters));
NotifyPropertyChanged(nameof(SignatureDisplay));
NotifyPropertyChanged(nameof(SignaturePreviewAutomationText));
NotifyPropertyChanged(nameof(IsOkButtonEnabled));
NotifyPropertyChanged(nameof(CanRemove));
NotifyPropertyChanged(nameof(RemoveAutomationText));
NotifyPropertyChanged(nameof(CanRestore));
NotifyPropertyChanged(nameof(RestoreAutomationText));
RemoveRestoreNotifyPropertyChanged();
}

internal void Restore()
{
AllParameters[_selectedIndex.Value].IsRemoved = false;
RemoveRestoreNotifyPropertyChanged();
}

internal void RemoveRestoreNotifyPropertyChanged()
{
NotifyPropertyChanged(nameof(AllParameters));
NotifyPropertyChanged(nameof(SignatureDisplay));
NotifyPropertyChanged(nameof(SignaturePreviewAutomationText));
@@ -146,6 +170,8 @@ internal void Restore()
NotifyPropertyChanged(nameof(RemoveAutomationText));
NotifyPropertyChanged(nameof(CanRestore));
NotifyPropertyChanged(nameof(RestoreAutomationText));
NotifyPropertyChanged(nameof(CanEdit));
NotifyPropertyChanged(nameof(EditAutomationText));
}

internal ParameterConfiguration GetParameterConfiguration()
@@ -388,6 +414,8 @@ public int? SelectedIndex
NotifyPropertyChanged(nameof(RemoveAutomationText));
NotifyPropertyChanged(nameof(CanRestore));
NotifyPropertyChanged(nameof(RestoreAutomationText));
NotifyPropertyChanged(nameof(CanEdit));
NotifyPropertyChanged(nameof(EditAutomationText));
}
}

@@ -443,6 +471,19 @@ public string RestoreAutomationText
}
}

public string EditAutomationText
{
get
{
if (!CanEdit)
{
return string.Empty;
}

return string.Format(ServicesVSResources.Edit_0, AllParameters[SelectedIndex.Value].ParameterAutomationText);
}
}

public class ParameterViewModel
{
private readonly ChangeSignatureDialogViewModel _changeSignatureDialogViewModel;
18 changes: 18 additions & 0 deletions src/VisualStudio/Core/Def/ServicesVSResources.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions src/VisualStudio/Core/Def/ServicesVSResources.resx
Original file line number Diff line number Diff line change
@@ -1356,4 +1356,11 @@ I agree to all of the foregoing:</value>
<data name="CSharp_Visual_Basic_Language_Server_Client" xml:space="preserve">
<value>C#/Visual Basic Language Server Client</value>
</data>
<data name="Edit" xml:space="preserve">
<value>_Edit</value>
</data>
<data name="Edit_0" xml:space="preserve">
<value>Edit {0}</value>
<comment>{0} is a parameter description</comment>
</data>
</root>
10 changes: 10 additions & 0 deletions src/VisualStudio/Core/Def/xlf/ServicesVSResources.cs.xlf
Original file line number Diff line number Diff line change
@@ -117,6 +117,16 @@
<target state="new">Current Document</target>
<note />
</trans-unit>
<trans-unit id="Edit">
<source>_Edit</source>
<target state="new">_Edit</target>
<note />
</trans-unit>
<trans-unit id="Edit_0">
<source>Edit {0}</source>
<target state="new">Edit {0}</target>
<note>{0} is a parameter description</note>
</trans-unit>
<trans-unit id="Element_is_not_valid">
<source>Element is not valid.</source>
<target state="translated">Element není platný.</target>
10 changes: 10 additions & 0 deletions src/VisualStudio/Core/Def/xlf/ServicesVSResources.de.xlf
Original file line number Diff line number Diff line change
@@ -117,6 +117,16 @@
<target state="new">Current Document</target>
<note />
</trans-unit>
<trans-unit id="Edit">
<source>_Edit</source>
<target state="new">_Edit</target>
<note />
</trans-unit>
<trans-unit id="Edit_0">
<source>Edit {0}</source>
<target state="new">Edit {0}</target>
<note>{0} is a parameter description</note>
</trans-unit>
<trans-unit id="Element_is_not_valid">
<source>Element is not valid.</source>
<target state="translated">Das Element ist ungültig.</target>
10 changes: 10 additions & 0 deletions src/VisualStudio/Core/Def/xlf/ServicesVSResources.es.xlf
Original file line number Diff line number Diff line change
@@ -117,6 +117,16 @@
<target state="new">Current Document</target>
<note />
</trans-unit>
<trans-unit id="Edit">
<source>_Edit</source>
<target state="new">_Edit</target>
<note />
</trans-unit>
<trans-unit id="Edit_0">
<source>Edit {0}</source>
<target state="new">Edit {0}</target>
<note>{0} is a parameter description</note>
</trans-unit>
<trans-unit id="Element_is_not_valid">
<source>Element is not valid.</source>
<target state="translated">El elemento no es válido.</target>
10 changes: 10 additions & 0 deletions src/VisualStudio/Core/Def/xlf/ServicesVSResources.fr.xlf
Original file line number Diff line number Diff line change
@@ -117,6 +117,16 @@
<target state="new">Current Document</target>
<note />
</trans-unit>
<trans-unit id="Edit">
<source>_Edit</source>
<target state="new">_Edit</target>
<note />
</trans-unit>
<trans-unit id="Edit_0">
<source>Edit {0}</source>
<target state="new">Edit {0}</target>
<note>{0} is a parameter description</note>
</trans-unit>
<trans-unit id="Element_is_not_valid">
<source>Element is not valid.</source>
<target state="translated">L'élément n'est pas valide.</target>
10 changes: 10 additions & 0 deletions src/VisualStudio/Core/Def/xlf/ServicesVSResources.it.xlf
Original file line number Diff line number Diff line change
@@ -117,6 +117,16 @@
<target state="new">Current Document</target>
<note />
</trans-unit>
<trans-unit id="Edit">
<source>_Edit</source>
<target state="new">_Edit</target>
<note />
</trans-unit>
<trans-unit id="Edit_0">
<source>Edit {0}</source>
<target state="new">Edit {0}</target>
<note>{0} is a parameter description</note>
</trans-unit>
<trans-unit id="Element_is_not_valid">
<source>Element is not valid.</source>
<target state="translated">L'elemento non è valido.</target>
10 changes: 10 additions & 0 deletions src/VisualStudio/Core/Def/xlf/ServicesVSResources.ja.xlf
Original file line number Diff line number Diff line change
@@ -117,6 +117,16 @@
<target state="new">Current Document</target>
<note />
</trans-unit>
<trans-unit id="Edit">
<source>_Edit</source>
<target state="new">_Edit</target>
<note />
</trans-unit>
<trans-unit id="Edit_0">
<source>Edit {0}</source>
<target state="new">Edit {0}</target>
<note>{0} is a parameter description</note>
</trans-unit>
<trans-unit id="Element_is_not_valid">
<source>Element is not valid.</source>
<target state="translated">要素が有効ではありません。</target>
10 changes: 10 additions & 0 deletions src/VisualStudio/Core/Def/xlf/ServicesVSResources.ko.xlf
Original file line number Diff line number Diff line change
@@ -117,6 +117,16 @@
<target state="new">Current Document</target>
<note />
</trans-unit>
<trans-unit id="Edit">
<source>_Edit</source>
<target state="new">_Edit</target>
<note />
</trans-unit>
<trans-unit id="Edit_0">
<source>Edit {0}</source>
<target state="new">Edit {0}</target>
<note>{0} is a parameter description</note>
</trans-unit>
<trans-unit id="Element_is_not_valid">
<source>Element is not valid.</source>
<target state="translated">요소가 잘못되었습니다.</target>
10 changes: 10 additions & 0 deletions src/VisualStudio/Core/Def/xlf/ServicesVSResources.pl.xlf
Original file line number Diff line number Diff line change
@@ -117,6 +117,16 @@
<target state="new">Current Document</target>
<note />
</trans-unit>
<trans-unit id="Edit">
<source>_Edit</source>
<target state="new">_Edit</target>
<note />
</trans-unit>
<trans-unit id="Edit_0">
<source>Edit {0}</source>
<target state="new">Edit {0}</target>
<note>{0} is a parameter description</note>
</trans-unit>
<trans-unit id="Element_is_not_valid">
<source>Element is not valid.</source>
<target state="translated">Element jest nieprawidłowy.</target>
10 changes: 10 additions & 0 deletions src/VisualStudio/Core/Def/xlf/ServicesVSResources.pt-BR.xlf
Original file line number Diff line number Diff line change
@@ -117,6 +117,16 @@
<target state="new">Current Document</target>
<note />
</trans-unit>
<trans-unit id="Edit">
<source>_Edit</source>
<target state="new">_Edit</target>
<note />
</trans-unit>
<trans-unit id="Edit_0">
<source>Edit {0}</source>
<target state="new">Edit {0}</target>
<note>{0} is a parameter description</note>
</trans-unit>
<trans-unit id="Element_is_not_valid">
<source>Element is not valid.</source>
<target state="translated">O elemento é inválido.</target>
10 changes: 10 additions & 0 deletions src/VisualStudio/Core/Def/xlf/ServicesVSResources.ru.xlf
Original file line number Diff line number Diff line change
@@ -117,6 +117,16 @@
<target state="new">Current Document</target>
<note />
</trans-unit>
<trans-unit id="Edit">
<source>_Edit</source>
<target state="new">_Edit</target>
<note />
</trans-unit>
<trans-unit id="Edit_0">
<source>Edit {0}</source>
<target state="new">Edit {0}</target>
<note>{0} is a parameter description</note>
</trans-unit>
<trans-unit id="Element_is_not_valid">
<source>Element is not valid.</source>
<target state="translated">Элемент недопустим.</target>
10 changes: 10 additions & 0 deletions src/VisualStudio/Core/Def/xlf/ServicesVSResources.tr.xlf
Original file line number Diff line number Diff line change
@@ -117,6 +117,16 @@
<target state="new">Current Document</target>
<note />
</trans-unit>
<trans-unit id="Edit">
<source>_Edit</source>
<target state="new">_Edit</target>
<note />
</trans-unit>
<trans-unit id="Edit_0">
<source>Edit {0}</source>
<target state="new">Edit {0}</target>
<note>{0} is a parameter description</note>
</trans-unit>
<trans-unit id="Element_is_not_valid">
<source>Element is not valid.</source>
<target state="translated">Öğe geçerli değil.</target>
10 changes: 10 additions & 0 deletions src/VisualStudio/Core/Def/xlf/ServicesVSResources.zh-Hans.xlf
Original file line number Diff line number Diff line change
@@ -117,6 +117,16 @@
<target state="new">Current Document</target>
<note />
</trans-unit>
<trans-unit id="Edit">
<source>_Edit</source>
<target state="new">_Edit</target>
<note />
</trans-unit>
<trans-unit id="Edit_0">
<source>Edit {0}</source>
<target state="new">Edit {0}</target>
<note>{0} is a parameter description</note>
</trans-unit>
<trans-unit id="Element_is_not_valid">
<source>Element is not valid.</source>
<target state="translated">元素无效。</target>
Loading