Merge master to features/interpolated-string-constants #45655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…volving nullability and generics
…624.3 (#45515) Microsoft.Net.Compilers.Toolset From Version 3.7.0-4.20319.6 -> To Version 3.7.0-4.20324.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Fix tests broken by two PRs "crossing".
* Update AttributeTests.cs * Update NullableReferenceTypesTests.cs * Update NullableReferenceTypesTests.cs * Fixed NullPointerException * Removed duplicate test * PR changes * Added Robustness and Nullable Checks * PR Changes * Moved test to avoid merge conflict
…on code fix Fixes #45446
Fixes #45465 Ensure we normalize the target scope passed to target symbol resolver. It doesn't handle the recently added 'namespaceanddescendants' scope in legacy target string format and expects it to be normalized to 'namespace' scope.
Fix issue preventing going to def on a complicated metadata symbol involving nullability and generics
Handle invalid dotnet_diagnostic entry without ID part in configurati…
Fix AD0001 for IDE0076
…in records with the latest design. (#45601) Related to #45296. From specification: If the record type is derived from a base record type Base, the record type includes a synthesized override of the strongly-typed Equals(Base other). The synthesized override is sealed. It is an error if the override is declared explicitly. The synthesized override returns Equals((object?)other). This change also adjusts code-gen to properly compare EqualityContracts.
Revert link to previous URL
…ed context should be treated as not constant (#45581)
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/interpolated-string-constants.
git fetch --all git checkout merges/master-to-features/interpolated-string-constants git reset --hard upstream/features/interpolated-string-constants git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/interpolated-string-constants --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.