VSMac: Make QuickFix preview resizable and add title #49394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therzok
reviewed
Nov 17, 2020
Therzok
reviewed
Nov 17, 2020
DavidKarlas
force-pushed
the
dev/davkar/quickFixPreview
branch
from
80e1d3b to
22da4da
Compare
DavidKarlas
force-pushed
the
dev/davkar/quickFixPreview
branch
from
22da4da to
ea4f27f
Compare
davidwengier
approved these changes
Nov 19, 2020
|
|
||
| #pragma warning disable IDE0052 // Remove unread private members | ||
| #pragma warning disable IDE0060 //Remove unused parameter |
There was a problem hiding this comment.
Which parameter is this for? Is it an analyzer false positive, or a valid complaint? It looks like everything is used here.
There was a problem hiding this comment.
In constructor optionPageGuid, logIdVerbatimInTelemetry...
There was a problem hiding this comment.
Before they were set to field but not anymore... Hence different warning...
There was a problem hiding this comment.
Oh right, yes of course. Do we need to keep them around, or are you just avoiding breaking VS for Mac?
I'm asking because of #48871 - we'd like to clean all of these up if we can, slowly.
There was a problem hiding this comment.
Its called from this project so it wouldn't break, its just that goal is to use all this in future, and removing it would need to delete code on PreviewPaneService.cs that we would have to re-add later...
This was referenced Nov 19, 2020
Closed
This PR makes few improvements to QuickFix preview to fit nicely in newer QuickFix design Also worked around missing `IPreviewDialogService`
DavidKarlas
force-pushed
the
dev/davkar/quickFixPreview
branch
from
ea4f27f to
0e9350a
Compare
ghost
added this to the 
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Nov 30, 2020
* upstream/master: (265 commits) Use extra generic type parameters and apply C#-specific knowledge to all langs instead of using inheritance Cover all changed code paths Stop removing parens that are required by C# Fix unnecessary spans Failing test for preserving parens around conditional expression AddSynthesizedRecordMembersIfNecessary - avoid touching members that are known to have no effect on the outcome of the function. (dotnet#49610) Resolve follow-up comments in PR "Create default arguments during binding" (dotnet#49588) Remove restore and checkout from test jobs (dotnet#49452) 3.8.* -> 3.9.* Update PublishData.json Update Versions.props Remove Microsoft.CodeAnalysis.VisualBasic.dll from the VSPE.OptProfTests.DDRIT_RPS_ManagedLangs_Typing runs Fix the ability to expand the list of analyzers in a reference Fix comment Address feedback to ensure `/warnaserror-:ID` prevents config options from bumping a warning to an error. parallel restore on mac/linux (dotnet#49523) VSMac: Make QuickFix preview resizable and add title (dotnet#49394) Add CallerMemberNameAttributeWithImplicitObjectCreation test (dotnet#49556) Update dependencies from https://github.com/dotnet/arcade build 20201120.10 (dotnet#49541) Clarify comment ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes few improvements to QuickFix preview to fit nicely in newer QuickFix design
Also worked around missing
IPreviewDialogService