Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel restore on mac/linux #49523

Merged
merged 1 commit into from
Nov 23, 2020
Merged

parallel restore on mac/linux #49523

merged 1 commit into from
Nov 23, 2020

Conversation

RikkiGibson
Copy link
Contributor

Revert of #33109

@RikkiGibson
Copy link
Contributor Author

Restore works locally on my Mac and works in the Unix build.

@RikkiGibson RikkiGibson marked this pull request as ready for review November 20, 2020 19:23
@RikkiGibson RikkiGibson requested a review from a team as a code owner November 20, 2020 19:23
@RikkiGibson
Copy link
Contributor Author

tagging @chsienki and @jaredpar before merging this in case you recall any other validation that needs to be done before we consider this safe to merge.

@RikkiGibson
Copy link
Contributor Author

I assume there is no objection, and if this introduces problems we can just revert :)

@RikkiGibson RikkiGibson merged commit edd866a into master Nov 23, 2020
@ghost ghost added this to the Next milestone Nov 23, 2020
@RikkiGibson RikkiGibson deleted the dev/rigibson/parallel-restore-unix branch November 23, 2020 18:16
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
333fred added a commit to 333fred/roslyn that referenced this pull request Nov 30, 2020
@333fred
Merge remote-tracking branch 'upstream/master' into merge-master
f3e4595 
* upstream/master: (265 commits)
  Use extra generic type parameters and apply C#-specific knowledge to all langs instead of using inheritance
  Cover all changed code paths
  Stop removing parens that are required by C#
  Fix unnecessary spans
  Failing test for preserving parens around conditional expression
  AddSynthesizedRecordMembersIfNecessary - avoid touching members that are known to have no effect on the outcome of the function. (dotnet#49610)
  Resolve follow-up comments in PR "Create default arguments during binding" (dotnet#49588)
  Remove restore and checkout from test jobs (dotnet#49452)
  3.8.* -> 3.9.*
  Update PublishData.json
  Update Versions.props
  Remove Microsoft.CodeAnalysis.VisualBasic.dll from the VSPE.OptProfTests.DDRIT_RPS_ManagedLangs_Typing runs
  Fix the ability to expand the list of analyzers in a reference
  Fix comment
  Address feedback to ensure `/warnaserror-:ID` prevents config options from bumping a warning to an error.
  parallel restore on mac/linux (dotnet#49523)
  VSMac: Make QuickFix preview resizable and add title (dotnet#49394)
  Add CallerMemberNameAttributeWithImplicitObjectCreation test (dotnet#49556)
  Update dependencies from https://github.com/dotnet/arcade build 20201120.10 (dotnet#49541)
  Clarify comment
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
16.9.P2
Development

Successfully merging this pull request may close these issues.
4 participants
@RikkiGibson @JoeRobich @allisonchou @Dotnet-GitSync-Bot