Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests with missing object property and missing collection property. #32348

Closed
ahsonkhan opened this issue Feb 15, 2020 · 0 comments · Fixed by #34559
Closed

Add tests with missing object property and missing collection property. #32348

ahsonkhan opened this issue Feb 15, 2020 · 0 comments · Fixed by #34559
Labels
area-System.Text.Json help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Milestone
5.0.0

Comments

@ahsonkhan
Copy link
Contributor

Capturing feedback from dotnet/corefx#35609 (comment)

runtime/src/libraries/System.Text.Json/tests/Serialization/PropertyVisibilityTests.cs

Lines 274 to 276 in dda29ff

// Todo: add tests with missing object property and missing collection property.
public class ClassWithPrivateSetterAndGetter

cc @steveharter @layomia
@ahsonkhan ahsonkhan added area-System.Text.Json test-enhancement Improvements of test source code labels Feb 15, 2020
@ahsonkhan ahsonkhan added this to the 5.0 milestone Feb 15, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Feb 15, 2020
@ahsonkhan ahsonkhan removed the untriaged New issue has not been triaged by the area owner label Feb 15, 2020
@ahsonkhan ahsonkhan mentioned this issue Feb 15, 2020
Merged
@ahsonkhan ahsonkhan added the help wanted [up-for-grabs] Good issue for external contributors label Feb 21, 2020
marcusturewicz added a commit to marcusturewicz/runtime that referenced this issue Apr 5, 2020
@marcusturewicz
Adds tests for missing object and collection properties in S.T.J.S
29d3c4b 
Adds two tests to ensure a missing object and a missing collection property are ignored when deserializing - the expected behaviour.

Fixes dotnet#32348
@marcusturewicz marcusturewicz mentioned this issue Apr 5, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Text.Json help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Adds tests for missing object and collection properties in S.T.J.S marcusturewicz/runtime
2 participants
@ahsonkhan @Dotnet-GitSync-Bot