Adds tests for missing object and collection properties in S.T.J.S #34559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two tests to ensure a missing object and a missing collection property are ignored when deserializing - the expected behaviour. Fixes dotnet#32348
marcusturewicz
requested review from
ahsonkhan,
jozkee,
layomia and
steveharter
as code owners
layomia
reviewed
Apr 5, 2020
There was a problem hiding this comment.
cc @steveharter on the intent of this comment/issue - #32348.
| ClassWithMissingObjectProperty obj | ||
| = JsonSerializer.Deserialize<ClassWithMissingObjectProperty>(@"{ ""Object"": {} }"); | ||
|
|
||
| Assert.NotNull(obj); |
There was a problem hiding this comment.
nit: we don't need this line as we'll hit a null ref on the next.
| ClassWithMissingCollectionProperty obj | ||
| = JsonSerializer.Deserialize<ClassWithMissingCollectionProperty>(@"{ ""Collection"": [] }"); | ||
|
|
||
| Assert.NotNull(obj); |
steveharter
approved these changes
Apr 6, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two tests to ensure a missing object and a missing collection property are ignored when deserializing - the expected behaviour.
Not sure if this is what you wanted, let me know.
Fixes #32348